search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

[Android] User is navigated to the collectible detail page after collectible sending instead of the activity tab #20701

Open VolodLytvynenko opened 2 months ago

VolodLytvynenko commented 2 months ago

Steps:

  1. Open an account (this step is required; don't send collectibles from the main wallet page).
  2. Open collectible -> tap 'send'
  3. Confirm collectible sending

Actual result:

After the collectible sending confirmation, the collectible detailed page is shown

https://github.com/status-im/status-mobile/assets/52490791/b00f8f9b-1fb7-4706-ba0c-f4c23d291910

Expected result:

After the collectible sending confirmation, the activity tab is shown

Devices:

Logs

Status-debug-logs (1).zip

ENV:

Nightly 9 Jul, 2024

OmarBasem commented 1 month ago

@VolodLytvynenko I am no longer reproducing this issue

VolodLytvynenko commented 1 month ago

@VolodLytvynenko I am no longer reproducing this issue

@OmarBasem hey. Still reproducible on my side. Used this PR https://github.com/status-im/status-mobile/pull/20902

https://github.com/user-attachments/assets/bb20aebe-49d3-4669-8709-3ee384f32cce

Logs:

Status-debug-logs (1).zip

OmarBasem commented 1 month ago

@VolodLytvynenko the current issue is about collectibles, right?

VolodLytvynenko commented 1 month ago

@VolodLytvynenko the current issue is about collectibles, right?

@OmarBasem correct. This issue is related only to collectibles sending

OmarBasem commented 1 month ago

@VolodLytvynenko I see the video you posted is for assets not collectibles

VolodLytvynenko commented 1 month ago

@VolodLytvynenko I see the video you posted is for assets not collectibles

@OmarBasem apologies. I mixed up the videos. I've just updated here

J-Son89 commented 1 month ago

@OmarBasem, @churik, @VolodLytvynenko - I think this flow looks "good enough". Maybe we can just leave this as is and avoid adding any new bugs in hope of fixing this one with such a short timeframe? wdyt?

OmarBasem commented 1 month ago

@J-Son89 I agree, doesn't look like a big issue to me

ulisesmac commented 1 month ago

A side note on this issue:

We should rework/extend the wizard to abstract a more general behavior so that the code is easier to maintain, right now the logic to handle all flows is complex.

CC: @J-Son89 @mmilad75

J-Son89 commented 1 month ago

Agreed @ulisesmac - I think we should also consider removing some of the entry points to make it easier to maintain and reduce the test coverage