search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Building dynamic tx results in tx with gasPrice #20781

Closed clauxx closed 4 weeks ago

clauxx commented 1 month ago

Bug Report

Problem

Currently, when building wallet connect transactions, we use wallet_buildTransaction and estimate the dynamic fees (EIP1559 when the chain supports it), but the resulting transaction also includes the gasPrice, which shouldn't be there as it's only for legacy transactions.

Expected behavior

No gasPrice in the built transaction

Actual behavior

gasPrice present in the built transaction

Reproduction

  1. Send transaction from https://react-app.walletconnect.com/ with wallet connect

Additional Information

clauxx commented 1 month ago

cc: @stefandunca

clauxx commented 4 weeks ago

irellevant since the gasPrice is not present in the final tx