search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 987 forks source link

activity center notifications are shown during onbaording #20820

Open jo-mut opened 3 months ago

jo-mut commented 3 months ago

As the user is onboarding and upon navigating to enable notifications screen, activity center notifications are shown obstructing the user from onboarding for a brief moment. These notifications if any should be shown on home page

https://github.com/user-attachments/assets/d8d2f362-00f8-4fe9-a8ea-695fd8562941

Expected behavior

Activity center notifications are displayed on the app home screen

Actual behavior

Activity center notifications might be displayed on enable notifications screen or welcome screen

Reproduction

Behaviour is observable with an account that has activity center notifications like contact requests

  1. Recover the account using seeephrase
  2. Navigate through onboarding to generate keys
  3. Navigate to enable notification screen
  4. Either on enable notifications or welcome page the AC notifications might be displayed

Additional Information

churik commented 2 months ago

I doubt that we can do anything about that rather than postponing these notifications or skipping them completely for users that just recovered their profiles (which is the best imo)

ilmotta commented 2 months ago

It appears to me that the root problem is that we should never display that many toasts at once in any screen, not just onboarding. Hence the solution is not simply to show them in the home screen after the onboarding.

A better solution could be to not show more than X notifications per Y window of time. If there's more, just don't show them because the user can see them in the Activity Center. This is relatively easy to implement, but I agree this issue is very low in our priority list.