status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.92k stars 984 forks source link

fix(wallet)_: Activity tab is selected on navigating back from the swap flow #21474

Closed smohamedjavid closed 1 month ago

smohamedjavid commented 1 month ago

fixes #21464

Summary

This PR fixes activity tab is selected when navigating back from the swap flow

Platforms

Steps to test

status: ready

status-im-auto commented 1 month ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 967a3ae8 #1 2024-10-21 16:09:21 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 967a3ae8 #2 2024-10-22 10:16:13 ~4 min tests :page_facing_up:log
:heavy_check_mark: 967a3ae8 #2 2024-10-22 10:18:40 ~7 min android :robot:apk :calling:
:heavy_check_mark: 967a3ae8 #2 2024-10-22 10:19:38 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5df60faa #3 2024-10-22 13:20:01 ~4 min tests :page_facing_up:log
:heavy_check_mark: 5df60faa #3 2024-10-22 13:21:55 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5df60faa #3 2024-10-22 13:23:50 ~8 min android :robot:apk :calling:
:heavy_check_mark: 5df60faa #2 2024-10-22 13:24:31 ~9 min ios :iphone:ipa :calling:
status-im-auto commented 1 month ago

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:311: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:330: in create_shared_drivers raise e base_test_case.py:320: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' ```

    Passed tests (7)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    VolodLytvynenko commented 1 month ago

    Hi @smohamedjavid, thank you for PR. No issues from my side. Ready to be merged