search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.92k stars 984 forks source link

fix(wallet)_: Chain prefix for ENS resolved address #21504

Closed smohamedjavid closed 3 weeks ago

smohamedjavid commented 1 month ago

fixes #20001

Summary

This PR removes chain prefixes being added to ENS resolved address in send flow

https://github.com/user-attachments/assets/f60645ba-af30-482a-822a-74101af8ebc3

Platforms

Areas that maybe impacted

Functional

Steps to test

status: ready

status-im-auto commented 1 month ago

Jenkins Builds

Click to see older builds (8) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | bcb6e0f7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21504/1/) | 2024-10-25 14:55:33 | ~4 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241025-145106-bcb6e0-pr21504-tests.log) | | :heavy_check_mark: | bcb6e0f7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21504/1/) | 2024-10-25 14:58:44 | ~7 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241025-145101-bcb6e0-pr21504-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241025-145101-bcb6e0-pr21504-arm64-v8a.apk)| | :heavy_check_mark: | bcb6e0f7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21504/1/) | 2024-10-25 14:59:14 | ~8 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241025-145101-bcb6e0-pr21504-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241025-145101-bcb6e0-pr21504-x86_64.apk)| | :x: | bcb6e0f7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21504/1/) | 2024-10-25 15:01:03 | ~10 min | `ios` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21504/1/consoleText) | | | | | | | | | | :heavy_check_mark: | 254961ed | [#2](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21504/2/) | 2024-10-28 10:31:13 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-102610-254961-pr21504-tests.log) | | :heavy_check_mark: | 254961ed | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21504/2/) | 2024-10-28 10:33:20 | ~7 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-102605-254961-pr21504-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241028-102605-254961-pr21504-arm64-v8a.apk)| | :heavy_check_mark: | 254961ed | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21504/2/) | 2024-10-28 10:34:08 | ~8 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-102605-254961-pr21504-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241028-102605-254961-pr21504-x86_64.apk)| | :heavy_check_mark: | 254961ed | [#2](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21504/2/) | 2024-10-28 10:36:03 | ~9 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/r8QzET) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2Fr8QzET)|
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 855a8ec1 #3 2024-11-01 12:41:57 ~4 min tests :page_facing_up:log
:heavy_check_mark: 855a8ec1 #3 2024-11-01 12:44:34 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 855a8ec1 #3 2024-11-01 12:45:28 ~8 min android :robot:apk :calling:
:heavy_check_mark: 855a8ec1 #3 2024-11-01 12:47:00 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: 181d37a3 #4 2024-11-01 15:34:16 ~4 min tests :page_facing_up:log
:heavy_check_mark: 181d37a3 #4 2024-11-01 15:37:02 ~7 min android :robot:apk :calling:
:heavy_check_mark: 181d37a3 #4 2024-11-01 15:37:19 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 181d37a3 #4 2024-11-01 15:39:29 ~9 min ios :iphone:ipa :calling:
status-im-auto commented 4 weeks ago

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 3
Expected to fail tests: 0
Passed tests: 5
IDs of failed tests: 703133,702742,702843

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Long press on `ChatElementByText`
    Device 1: Find `Button` by `xpath`: `//*[@text="Copy text"]`

    ``` critical/chats/test_public_chat_browsing.py:59: in test_community_copy_and_paste_message_in_chat_input self.channel.copy_message_text(message) ../views/chat_view.py:1038: in copy_message_text self.element_by_translation_id("copy-text").click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//*[@text="Copy text"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ```

    Device sessions

    Passed tests (5)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    status-im-auto commented 3 weeks ago

    75% of end-end tests have passed

    Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
    IDs of failed tests: 703133,702843

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Passed tests (6)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229
    Horupa-Olena commented 3 weeks ago

    @smohamedjavid Thank you for your PR! All looks great, you can merge it.