search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.92k stars 984 forks source link

chore_: Remove Goerli code #21508

Closed smohamedjavid closed 3 weeks ago

smohamedjavid commented 4 weeks ago

fixes #20273

Summary

This PR removes the goerli-related code from the mobile repo.

Review notes

We removed just the Goerli toggle from the old advanced settings (https://github.com/status-im/status-mobile/pull/20875) 3 months back when Goerli ceased to exist.

The PR will NOT bring any functional changes to the app. The app will work as before.

Testing notes

A complete regression testing on the app is appreciated.

Note: The testnet mode (sepolia) is enabled by default on Dev, PR, and E2E builds as before. This PR doesn't change that.

Platforms

Areas that may be impacted

Functional

status: ready

status-im-auto commented 4 weeks ago

Jenkins Builds

Click to see older builds (5) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 80b797b7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21508/1/) | 2024-10-28 13:04:40 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-125931-80b797-pr21508-tests.log) | | :heavy_check_mark: | 80b797b7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21508/1/) | 2024-10-28 13:06:58 | ~7 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-125926-80b797-pr21508-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241028-125926-80b797-pr21508-x86_64.apk)| | :heavy_check_mark: | 80b797b7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21508/1/) | 2024-10-28 13:09:29 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-125931-80b797-pr21508-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241028-125931-80b797-pr21508-arm64-v8a.apk)| | :heavy_check_mark: | 80b797b7 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21508/1/) | 2024-10-28 13:12:40 | ~13 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/p6a4ax) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2Fp6a4ax)| | | | | | | | | | :x: | 74036acf | [#2](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21508/2/) | 2024-10-29 10:10:49 | ~2 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21508/2/consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: d43926ba #3 2024-10-29 10:22:56 ~9 min tests :page_facing_up:log
:heavy_check_mark: d43926ba #3 2024-10-29 10:23:50 ~10 min android-e2e :robot:apk :calling:
:heavy_check_mark: d43926ba #3 2024-10-29 10:24:24 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: d43926ba #3 2024-10-29 10:24:51 ~11 min android :robot:apk :calling:
:heavy_check_mark: 5bc8f10a #4 2024-11-04 09:44:39 ~5 min tests :page_facing_up:log
:heavy_check_mark: 5bc8f10a #4 2024-11-04 09:46:32 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5bc8f10a #4 2024-11-04 09:48:18 ~9 min android :robot:apk :calling:
:heavy_check_mark: 5bc8f10a #4 2024-11-04 09:48:45 ~9 min ios :iphone:ipa :calling:
vkjr commented 4 weeks ago

Nice cleanup! Thank you!

status-im-auto commented 4 weeks ago

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 3
Expected to fail tests: 0
Passed tests: 5
IDs of failed tests: 703133,702745,702843

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Find `AllowButton` by `xpath`: `//*[@text="Allow" or @text="ALLOW"]`
    ## New multiaccount is created successfully!

    ``` Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../views/sign_in_view.py:246: in create_user self.terms_and_privacy_checkbox.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ```

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Passed tests (5)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229
    status-im-auto commented 3 weeks ago

    33% of end-end tests have passed

    Total executed tests: 3
Failed tests: 2
Expected to fail tests: 0
Passed tests: 1
    IDs of failed tests: 703133,702843

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Passed tests (1)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    VolodLytvynenko commented 3 weeks ago

    hi @smohamedjavid thank you for PR. No issues from my side. PR is ready to be merged