search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Fix wallet action buttons alignment #21514

Closed clauxx closed 3 weeks ago

clauxx commented 1 month ago

fixes #21513

Summary

Fixes included:

  1. dynamic spacing of wallet actions based on designs
  2. updated the bridge icon

status: ready

status-im-auto commented 1 month ago

Jenkins Builds

Click to see older builds (24) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 3043f2c6 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21514/1/) | 2024-10-28 16:49:58 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-164431-3043f2-pr21514-tests.log) | | :heavy_check_mark: | 3043f2c6 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21514/1/) | 2024-10-28 16:53:35 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-164426-3043f2-pr21514-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241028-164426-3043f2-pr21514-x86_64.apk)| | :heavy_check_mark: | 3043f2c6 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21514/1/) | 2024-10-28 16:54:24 | ~9 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/THMuyB) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FTHMuyB)| | :heavy_check_mark: | 3043f2c6 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21514/1/) | 2024-10-28 16:54:24 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241028-164431-3043f2-pr21514-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241028-164431-3043f2-pr21514-arm64-v8a.apk)| | | | | | | | | | :heavy_check_mark: | 94f40e5f | [#2](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21514/2/) | 2024-10-29 10:25:28 | ~8 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241029-101724-94f40e-pr21514-tests.log) | | :heavy_check_mark: | 94f40e5f | [#2](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21514/2/) | 2024-10-29 10:26:07 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/WUmtWo) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FWUmtWo)| | :heavy_check_mark: | 94f40e5f | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21514/2/) | 2024-10-29 10:29:30 | ~12 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241029-101724-94f40e-pr21514-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241029-101724-94f40e-pr21514-arm64-v8a.apk)| | :heavy_check_mark: | 94f40e5f | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21514/2/) | 2024-10-29 10:30:32 | ~13 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241029-101724-94f40e-pr21514-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241029-101724-94f40e-pr21514-x86_64.apk)| | | | | | | | | | :heavy_check_mark: | 714e4cd9 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21514/3/) | 2024-11-01 11:06:01 | ~4 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241101-110121-714e4c-pr21514-tests.log) | | :heavy_check_mark: | 714e4cd9 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21514/3/) | 2024-11-01 11:09:16 | ~7 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241101-110117-714e4c-pr21514-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241101-110117-714e4c-pr21514-x86_64.apk)| | :heavy_check_mark: | 714e4cd9 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21514/3/) | 2024-11-01 11:09:49 | ~8 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241101-110117-714e4c-pr21514-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241101-110117-714e4c-pr21514-arm64-v8a.apk)| | :heavy_check_mark: | 714e4cd9 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21514/3/) | 2024-11-01 11:09:55 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/mis144) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2Fmis144)| | | | | | | | | | :heavy_check_mark: | 3a8dc7f1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21514/4/) | 2024-11-01 21:52:13 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241101-214700-3a8dc7-pr21514-tests.log) | | :heavy_check_mark: | 3a8dc7f1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21514/4/) | 2024-11-01 21:56:33 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241101-214700-3a8dc7-pr21514-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241101-214700-3a8dc7-pr21514-x86_64.apk)| | :heavy_check_mark: | 3a8dc7f1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21514/4/) | 2024-11-01 21:57:07 | ~10 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241101-214700-3a8dc7-pr21514-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241101-214700-3a8dc7-pr21514-arm64-v8a.apk)| | :heavy_check_mark: | 3a8dc7f1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21514/4/) | 2024-11-01 21:57:49 | ~10 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/rFRMYU) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FrFRMYU)| | | | | | | | | | :heavy_check_mark: | 5ed4cc0f | [#5](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21514/5/) | 2024-11-04 11:53:33 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241104-114800-5ed4cc-pr21514-tests.log) | | :heavy_check_mark: | 5ed4cc0f | [#5](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21514/5/) | 2024-11-04 11:55:13 | ~7 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241104-114800-5ed4cc-pr21514-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241104-114800-5ed4cc-pr21514-arm64-v8a.apk)| | :heavy_check_mark: | 5ed4cc0f | [#5](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21514/5/) | 2024-11-04 11:56:26 | ~8 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241104-114800-5ed4cc-pr21514-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241104-114800-5ed4cc-pr21514-x86_64.apk)| | :heavy_check_mark: | 5ed4cc0f | [#5](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21514/5/) | 2024-11-04 11:56:46 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/moCXLm) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FmoCXLm)| | | | | | | | | | :heavy_check_mark: | a5b0ee4d | [#7](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21514/7/) | 2024-11-04 12:16:41 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241104-121100-a5b0ee-pr21514-tests.log) | | :heavy_check_mark: | a5b0ee4d | [#7](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21514/7/) | 2024-11-04 12:20:23 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241104-121055-a5b0ee-pr21514-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241104-121055-a5b0ee-pr21514-x86_64.apk)| | :heavy_check_mark: | a5b0ee4d | [#7](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21514/7/) | 2024-11-04 12:20:27 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241104-121055-a5b0ee-pr21514-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241104-121055-a5b0ee-pr21514-arm64-v8a.apk)| | :heavy_check_mark: | a5b0ee4d | [#7](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21514/7/) | 2024-11-04 12:22:38 | ~11 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/M7XMDc) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FM7XMDc)|
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: a6e15dbd #8 2024-11-04 15:06:04 ~4 min tests :page_facing_up:log
:heavy_check_mark: a6e15dbd #8 2024-11-04 15:08:16 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: a6e15dbd #8 2024-11-04 15:09:27 ~8 min android :robot:apk :calling:
:heavy_check_mark: a6e15dbd #8 2024-11-04 15:10:17 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 1f0406b9 #9 2024-11-04 16:21:21 ~4 min tests :page_facing_up:log
:heavy_check_mark: 1f0406b9 #9 2024-11-04 16:24:53 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 1f0406b9 #9 2024-11-04 16:25:27 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: 1f0406b9 #9 2024-11-04 16:25:57 ~9 min android :robot:apk :calling:
status-im-auto commented 1 month ago

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 703133,702843

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    status-im-auto commented 4 weeks ago

    75% of end-end tests have passed

    Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
    IDs of failed tests: 703133,702843

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices self.community_2.join_community() ../views/chat_view.py:420: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Passed tests (6)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Horupa-Olena commented 4 weeks ago

    @clauxx Thank you for the PR. I tested it on a device with a resolution of 750x1334 (couldn’t find a smaller device) — everything looks good. I didn’t notice any regressions on other devices.

    You can go ahead and merge this PR.

    clauxx commented 4 weeks ago

    @clauxx Thank you for the PR. I tested it on a device with a resolution of 750x1334 (couldn’t find a smaller device) — everything looks good. I didn’t notice any regressions on other devices.

    You can go ahead and merge this PR.

    Thanks!