status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.92k stars 984 forks source link

"Keycard is not empty" screen appears at the wrong place of migration flow #21601

Closed mariia-skrypnyk closed 1 week ago

mariia-skrypnyk commented 2 weeks ago

Bug Report

https://github.com/status-im/status-mobile/pull/21467

Problem

User has an empty Keycard and NOT backuped Profile. In the middle of the migration flow user closes Ready to migrate profile screen and then starts flow one more time then his keycard is no longer empty but no check on this till we come to the PIN entering step. But check if our Keycard ready or not should be right after Check your card screen ( at the beginnig of the flow) and not at the end when we enter PIN. Please, look at the video to observe my test scenario.

Actual behavior

00:27 - I cut my migration flow and return to the beginning 01:10 - Here should be a check that my Keycard is not empty 01:37 - Keycard is not empty screen

https://github.com/user-attachments/assets/0855ed7b-4843-4287-a02e-d0efd6771706

Expected behavior

Check that my Keycard is not emptyscreen should be after Check your card screen

Image

https://www.figma.com/design/YGm3igIOAcwMqUVJWCJ6f1/Keycard-UX?node-id=3-89231&node-type=canvas&t=jRHi23c8KvoA2g3u-0

Reproduction

  1. Test data: empty Keycard and not backup-ed Profile
  2. Login to App
  3. Turn on Keycard feature flag
  4. Make sure your Keycard is empty and your Profile is NOT backup-ed
  5. Go through the migration flow and close the screen when you'll see Ready to migrate your Profile screen
  6. Go through the flow one more time

Additional Information