Closed Parveshdhull closed 1 week ago
:grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
---|---|---|---|---|---|---|
:heavy_check_mark: | 5deae470 | #5 | 2024-11-11 06:05:44 | ~4 min | tests |
:page_facing_up:log |
:heavy_check_mark: | 5deae470 | #5 | 2024-11-11 06:08:52 | ~7 min | android |
:robot:apk :calling: |
:heavy_check_mark: | 5deae470 | #5 | 2024-11-11 06:09:02 | ~8 min | android-e2e |
:robot:apk :calling: |
:heavy_check_mark: | 5deae470 | #5 | 2024-11-11 06:11:14 | ~10 min | ios |
:iphone:ipa :calling: |
:heavy_check_mark: | 028f959b | #6 | 2024-11-12 09:41:57 | ~5 min | tests |
:page_facing_up:log |
:heavy_check_mark: | 028f959b | #6 | 2024-11-12 09:46:01 | ~9 min | android-e2e |
:robot:apk :calling: |
:heavy_check_mark: | 028f959b | #6 | 2024-11-12 09:46:34 | ~9 min | android |
:robot:apk :calling: |
:heavy_check_mark: | 028f959b | #6 | 2024-11-12 09:46:53 | ~9 min | ios |
:iphone:ipa :calling: |
Total executed tests: 8
Failed tests: 7
Expected to fail tests: 1
Passed tests: 0
IDs of failed tests: 727230,727231,702745,702742,740490,727229,703133
IDs of expected to fail tests: 702843
1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
``` Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../views/sign_in_view.py:247: in create_user self.terms_and_privacy_checkbox.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` Device sessions Device 1: Device 2: |
1. test_wallet_add_remove_regular_account, id: 727231 |
```
Test setup failed: critical/test_wallet.py:210: in prepare_devices
self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username)
../views/sign_in_view.py:295: in recover_access
self.terms_and_privacy_checkbox.click()
../views/base_element.py:90: in click
element = self.find_element()
../views/base_element.py:79: in find_element
raise NoSuchElementException(
Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
```
|
2. test_wallet_balance_mainnet, id: 740490 |
``` Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:295: in recover_access self.terms_and_privacy_checkbox.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` |
1. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
``` Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:247: in create_user self.terms_and_privacy_checkbox.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` Device sessions Device 1: |
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133 |
```
Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
self.home = self.sign_in.create_user(username=self.username)
../views/sign_in_view.py:247: in create_user
self.terms_and_privacy_checkbox.click()
../views/base_element.py:90: in click
element = self.find_element()
../views/base_element.py:79: in find_element
raise NoSuchElementException(
Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
```
|
1. test_wallet_send_asset_from_drawer, id: 727230 |
```
Test setup failed: critical/test_wallet.py:28: in prepare_devices
self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
return future.result()
__init__.py:52: in run_in_parallel
returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:295: in recover_access
self.terms_and_privacy_checkbox.click()
../views/base_element.py:90: in click
element = self.find_element()
../views/base_element.py:79: in find_element
raise NoSuchElementException(
Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
```
|
2. test_wallet_send_eth, id: 727229 |
``` Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../views/sign_in_view.py:295: in recover_access self.terms_and_privacy_checkbox.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` |
1. test_community_message_edit, id: 702843 |
```
Test is not run, e2e blocker
```
[[reason: [NOTRUN] Skipped due to waku issue on staging fleet]] |
It seems that we also need to update the end-to-end tests to align with the new onboarding changes. cc: @status-im/mobile-qa
It seems that we also need to update the end-to-end tests to align with the new onboarding changes. cc: @status-im/mobile-qa
Thanks for the PR and pinging @Parveshdhull
@yevh-berdnyk could you please take a look?
have you looked if it's possible to simplify improve performance of this screen?
Hi, For now, I’m primarily focused on UI changes to prepare the onboarding migration for 2.32.0. (Removal of code/features should give at least some performance improvement)
Regarding the intro screen, I believe the heaviest component is the background carousel. I think In trying to make it reusable, we ended up complicating it with tangled logic and an unusual blur overlay state management. I can revisit this once the migration is complete.
Please let me know if you have any suggestions.
Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6
IDs of failed tests: 703133
IDs of expected to fail tests: 702843
1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133 |
``` critical/chats/test_public_chat_browsing.py:243: in test_restore_multiaccount_with_waku_backup_remove_profile_switch self.sign_in.show_profiles_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element ``` Device sessions Device 1: |
1. test_community_message_edit, id: 702843 |
```
Test is not run, e2e blocker
```
[[reason: [NOTRUN] Skipped due to waku issue on staging fleet]] |
1. test_wallet_add_remove_regular_account, id: 727231 |
2. test_wallet_balance_mainnet, id: 740490 |
1. test_wallet_send_asset_from_drawer, id: 727230 |
2. test_wallet_send_eth, id: 727229 |
1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
Device sessions Device 1: Device 2: |
1. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
Device sessions Device 1: |
UPD: not relevant
Hi @Parveshdhull, thanks for the PR! I've updated e2e tests and now I see that one of the tests fails because of the next issue: Having 2 profiles on the device we remove one of them. After that we terminate the app, restart it and got the next screen:
But we expect the remaining profile to be shown on this step. Please look at the video:
https://github.com/user-attachments/assets/c37792b5-2b4b-4c7e-a9f0-91794d27b691
Hi @Parveshdhull, thanks for the PR! I've updated e2e tests and now I see that one of the tests fails because of the next issue: Having 2 profiles on the device we remove one of them. After that we terminate the app, restart it and got the next screen: But we expect the remaining profile to be shown on this step. Please look at the video:
2024-11-08.19.51.52.mp4
@Parveshdhull sorry, I've missed that this screen was added in other PR and it's expected :( I'll finish with updating the tests right now
Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7
IDs of expected to fail tests: 702843
1. test_community_message_edit, id: 702843 |
```
Test is not run, e2e blocker
```
[[reason: [NOTRUN] Skipped due to waku issue on staging fleet]] |
1. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
Device sessions Device 1: |
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133 |
Device sessions Device 1: |
1. test_wallet_add_remove_regular_account, id: 727231 |
2. test_wallet_balance_mainnet, id: 740490 |
1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
Device sessions Device 1: Device 2: |
1. test_wallet_send_asset_from_drawer, id: 727230 |
2. test_wallet_send_eth, id: 727229 |
hi, @Francesca-G PR is ready for design review, thank you
hi, @Francesca-G PR is ready for design review, thank you
Hello! Design isn't locked yet for this, the Figma file of the simplified onboarding is still a WIP. Please refer to Pedro for any question :)
We agreed that onboarding simplification PRs will be merged without a design review. Once the designs are finalized, we can review these screens and give them the final touch.
Skipping manual QA as the PR is simple, minor, and self-tested.
fixes https://github.com/status-im/status-mobile/issues/21562 fixes https://github.com/status-im/status-mobile/issues/21561
https://github.com/user-attachments/assets/2776f640-bbc9-4b9f-beb2-e33a1da58880
status: ready