status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.92k stars 984 forks source link

Remove onboarding generating keys screen #21608

Closed Parveshdhull closed 1 week ago

Parveshdhull commented 2 weeks ago

fixes https://github.com/status-im/status-mobile/issues/21569

Testing note:

Please lightly test PR to make sure loading screen is not broken in any flows.

status: ready

status-im-auto commented 2 weeks ago

Jenkins Builds

Click to see older builds (27) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :x: | 5b73b2b2 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/1/) | 2024-11-08 10:28:35 | ~47 sec | `android-e2e` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/1/consoleText) | | :x: | 5b73b2b2 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/1/) | 2024-11-08 10:28:37 | ~49 sec | `android` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/1/consoleText) | | :x: | 5b73b2b2 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/1/) | 2024-11-08 10:28:39 | ~50 sec | `ios` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/1/consoleText) | | | | | | | | | | :x: | f84f9514 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/2/) | 2024-11-08 10:31:11 | ~27 sec | `ios` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/2/consoleText) | | :x: | f84f9514 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/2/) | 2024-11-08 10:31:30 | ~47 sec | `android` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/2/consoleText) | | :x: | f84f9514 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/2/) | 2024-11-08 10:32:35 | ~1 min | `android-e2e` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/2/consoleText) | | :x: | f84f9514 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/2/) | 2024-11-08 10:33:31 | ~2 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/2/consoleText) | | | | | | | | | | :x: | 97a7fc72 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/3/) | 2024-11-08 10:36:38 | ~2 min | `ios` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/3/consoleText) | | :heavy_check_mark: | 97a7fc72 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/3/) | 2024-11-08 10:38:37 | ~4 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241108-103412-97a7fc-pr21608-tests.log) | | :heavy_check_mark: | 97a7fc72 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/3/) | 2024-11-08 10:42:03 | ~7 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241108-103407-97a7fc-pr21608-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241108-103407-97a7fc-pr21608-x86_64.apk)| | :heavy_check_mark: | 97a7fc72 | [#3](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/3/) | 2024-11-08 10:42:37 | ~8 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241108-103407-97a7fc-pr21608-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241108-103407-97a7fc-pr21608-arm64-v8a.apk)| | | | | | | | | | :heavy_check_mark: | 1d038ed1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/4/) | 2024-11-11 06:10:42 | ~4 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241111-060618-1d038e-pr21608-tests.log) | | :heavy_check_mark: | 1d038ed1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/4/) | 2024-11-11 06:13:19 | ~7 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241111-060614-1d038e-pr21608-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241111-060614-1d038e-pr21608-x86_64.apk)| | :heavy_check_mark: | 1d038ed1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/4/) | 2024-11-11 06:14:10 | ~7 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241111-060614-1d038e-pr21608-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241111-060614-1d038e-pr21608-arm64-v8a.apk)| | :heavy_check_mark: | 1d038ed1 | [#4](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/4/) | 2024-11-11 06:17:32 | ~11 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/G7Hg7s) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FG7Hg7s)| | | | | | | | | | :heavy_check_mark: | 3b6e4b3e | [#5](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/5/) | 2024-11-12 10:04:23 | ~4 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-100014-3b6e4b-pr21608-tests.log) | | :heavy_check_mark: | 3b6e4b3e | [#5](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/5/) | 2024-11-12 10:07:58 | ~7 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-100009-3b6e4b-pr21608-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241112-100009-3b6e4b-pr21608-x86_64.apk)| | :heavy_check_mark: | 3b6e4b3e | [#5](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/5/) | 2024-11-12 10:08:36 | ~8 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-100014-3b6e4b-pr21608-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241112-100014-3b6e4b-pr21608-arm64-v8a.apk)| | :heavy_check_mark: | 3b6e4b3e | [#5](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/5/) | 2024-11-12 10:09:54 | ~9 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/UgLiDH) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FUgLiDH)| | | | | | | | | | :heavy_check_mark: | 547c7705 | [#6](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/6/) | 2024-11-12 16:01:09 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-155558-547c77-pr21608-tests.log) | | :heavy_check_mark: | 547c7705 | [#6](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/6/) | 2024-11-12 16:04:44 | ~8 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-155553-547c77-pr21608-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241112-155553-547c77-pr21608-x86_64.apk)| | :heavy_check_mark: | 547c7705 | [#6](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/6/) | 2024-11-12 16:05:20 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-155556-547c77-pr21608-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241112-155556-547c77-pr21608-arm64-v8a.apk)| | :heavy_check_mark: | 547c7705 | [#6](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/6/) | 2024-11-12 16:05:36 | ~9 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/nrEXmv) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FnrEXmv)| | | | | | | | | | :heavy_check_mark: | e03e5417 | [#7](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21608/7/) | 2024-11-12 16:12:53 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-160748-e03e54-pr21608-tests.log) | | :heavy_check_mark: | e03e5417 | [#7](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21608/7/) | 2024-11-12 16:16:41 | ~8 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-160748-e03e54-pr21608-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241112-160748-e03e54-pr21608-x86_64.apk)| | :heavy_check_mark: | e03e5417 | [#7](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21608/7/) | 2024-11-12 16:17:21 | ~9 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/qLTczL) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FqLTczL)| | :heavy_check_mark: | e03e5417 | [#7](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21608/7/) | 2024-11-12 16:17:26 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241112-160748-e03e54-pr21608-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241112-160748-e03e54-pr21608-arm64-v8a.apk)|
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: b3a8b696 #8 2024-11-12 18:38:05 ~4 min tests :page_facing_up:log
:heavy_check_mark: b3a8b696 #8 2024-11-12 18:41:27 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: b3a8b696 #8 2024-11-12 18:43:18 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: d546a706 #9 2024-11-12 19:11:07 ~4 min tests :page_facing_up:log
:heavy_check_mark: d546a706 #9 2024-11-12 19:13:06 ~6 min android :robot:apk :calling:
:heavy_check_mark: d546a706 #9 2024-11-12 19:14:09 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: d546a706 #9 2024-11-12 19:15:45 ~9 min ios :iphone:ipa :calling:
status-im-auto commented 2 weeks ago

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 1
Passed tests: 5
IDs of failed tests: 727230,727229 
IDs of expected to fail tests: 702843 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    ``` Test setup failed: critical/test_wallet.py:22: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:330: in create_shared_drivers raise e base_test_case.py:320: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' ```

    2. test_wallet_send_eth, id: 727229
    ``` Test setup failed: critical/test_wallet.py:22: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:330: in create_shared_drivers raise e base_test_case.py:320: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' ```

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    ``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

    Passed tests (5)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    pavloburykh commented 1 week ago

    @Parveshdhull thanks for the PR! No issues from my side. Ready for merge.