status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

[#21573] Keycard - Sign up with a new Keycard #21623

Open flexsurfer opened 1 week ago

flexsurfer commented 1 week ago

fixes #21573

status-im-auto commented 1 week ago

Jenkins Builds

Click to see older builds (8) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :x: | 2fd7dca8 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21623/1/) | 2024-11-14 11:37:48 | ~3 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21623/1/consoleText) | | :heavy_check_mark: | 2fd7dca8 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21623/1/) | 2024-11-14 11:41:46 | ~7 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241114-113440-2fd7dc-pr21623-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241114-113440-2fd7dc-pr21623-x86_64.apk)| | :heavy_check_mark: | 2fd7dca8 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21623/1/) | 2024-11-14 11:43:19 | ~8 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241114-113440-2fd7dc-pr21623-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241114-113440-2fd7dc-pr21623-arm64-v8a.apk)| | :heavy_check_mark: | 2fd7dca8 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21623/1/) | 2024-11-14 11:43:39 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/aWR5zM) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FaWR5zM)| | | | | | | | | | :x: | 16fc3938 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21623/2/) | 2024-11-20 15:12:27 | ~2 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21623/2/consoleText) | | :heavy_check_mark: | 16fc3938 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21623/2/) | 2024-11-20 15:19:24 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241120-150951-16fc39-pr21623-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241120-150951-16fc39-pr21623-x86_64.apk)| | :heavy_check_mark: | 16fc3938 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21623/2/) | 2024-11-20 15:20:28 | ~10 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/xHJoJR) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FxHJoJR)| | :heavy_check_mark: | 16fc3938 | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21623/2/) | 2024-11-20 15:21:04 | ~11 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241120-150951-16fc39-pr21623-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241120-150951-16fc39-pr21623-arm64-v8a.apk)|
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 97ad702d #3 2024-11-20 15:34:43 ~4 min tests :page_facing_up:log
:heavy_check_mark: 97ad702d #3 2024-11-20 15:37:07 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 97ad702d #3 2024-11-20 15:37:54 ~7 min android :robot:apk :calling:
:heavy_check_mark: 97ad702d #3 2024-11-20 15:38:47 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: b2d9a169 #4 2024-11-22 13:28:45 ~4 min tests :page_facing_up:log
:heavy_check_mark: b2d9a169 #4 2024-11-22 13:30:50 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: b2d9a169 #4 2024-11-22 13:31:19 ~7 min android :robot:apk :calling:
:heavy_check_mark: b2d9a169 #4 2024-11-22 13:33:06 ~9 min ios :iphone:ipa :calling:
status-im-auto commented 2 days ago

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7
IDs of expected to fail tests: 702843 

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229
mariia-skrypnyk commented 1 day ago

Hey @flexsurfer !

Thanks for your PR!

I found one issue with PIN code validation. Please take a look!

ISSUE 1: no PIN validation in case user enters wrong PIN

Precondition: Keycard with a set PIN

Steps:

1) Install app 2) Go to Create user with a Keycard 3) Scan Keycard 4) Enter wrong PIN 5) Scan Keycard 6) Scan Keycard 2-3 times more and you will get locked card

Actual result:

no validation that PIN is incorrect

https://github.com/user-attachments/assets/6458cffa-630a-4e78-8a08-af8476826e3b

Expected result:

as a User I would like to see smth like this

Screenshot 2024-11-21 at 16 40 14
flexsurfer commented 2 hours ago

thank you @mariia-skrypnyk should be fixed

mariia-skrypnyk commented 1 hour ago

Hi @flexsurfer !

No text with number of attempts on both platforms.

Screenshot 2024-11-22 at 16 10 19
flexsurfer commented 1 hour ago

No text with number of attempts on both platforms.

i believe there is a separate bug which i can't reproduce :(