search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Onboarding skip enable notifications screen #21633

Closed Parveshdhull closed 2 days ago

Parveshdhull commented 4 days ago

fixes https://github.com/status-im/status-mobile/issues/21627

Video

https://github.com/user-attachments/assets/b253460d-955a-45b5-acca-99d14a883924

Testing

status: ready

status-im-auto commented 4 days ago

Jenkins Builds

Click to see older builds (20) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 44240849 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21633/1/) | 2024-11-18 09:24:07 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241118-091839-442408-pr21633-tests.log) | | :heavy_check_mark: | 44240849 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21633/1/) | 2024-11-18 09:28:14 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241118-091834-442408-pr21633-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241118-091834-442408-pr21633-x86_64.apk)| | :heavy_check_mark: | 44240849 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21633/1/) | 2024-11-18 09:28:47 | ~10 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241118-091834-442408-pr21633-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241118-091834-442408-pr21633-arm64-v8a.apk)| | :heavy_check_mark: | 44240849 | [#1](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21633/1/) | 2024-11-18 09:28:53 | ~10 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/SpN7mt) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FSpN7mt)| | | | | | | | | | :x: | 4441af2a | [#2](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21633/2/) | 2024-11-18 11:28:14 | ~4 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21633/2/consoleText) | | :heavy_check_mark: | 4441af2a | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21633/2/) | 2024-11-18 11:32:25 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241118-112316-4441af-pr21633-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241118-112316-4441af-pr21633-x86_64.apk)| | :heavy_check_mark: | 4441af2a | [#2](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21633/2/) | 2024-11-18 11:33:07 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241118-112321-4441af-pr21633-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241118-112321-4441af-pr21633-arm64-v8a.apk)| | :heavy_check_mark: | 4441af2a | [#2](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21633/2/) | 2024-11-18 11:33:19 | ~9 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/BpRWcT) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FBpRWcT)| | | | | | | | | | :heavy_check_mark: | 2c44985a | [#3](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21633/3/) | 2024-11-19 12:04:28 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-115913-2c4498-pr21633-tests.log) | | :heavy_check_mark: | 2c44985a | [#3](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21633/3/) | 2024-11-19 12:08:09 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/xw25fV) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2Fxw25fV)| | :heavy_check_mark: | 2c44985a | [#3](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21633/3/) | 2024-11-19 12:08:26 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-115913-2c4498-pr21633-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241119-115913-2c4498-pr21633-x86_64.apk)| | :heavy_check_mark: | 2c44985a | [#3](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21633/3/) | 2024-11-19 12:08:56 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-115913-2c4498-pr21633-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241119-115913-2c4498-pr21633-arm64-v8a.apk)| | | | | | | | | | :heavy_check_mark: | a5851d8e | [#4](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21633/4/) | 2024-11-19 13:09:49 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-130448-a5851d-pr21633-tests.log) | | :heavy_check_mark: | a5851d8e | [#4](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21633/4/) | 2024-11-19 13:13:31 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/odvqPD) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2FodvqPD)| | :heavy_check_mark: | a5851d8e | [#4](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21633/4/) | 2024-11-19 13:13:56 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-130443-a5851d-pr21633-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241119-130443-a5851d-pr21633-x86_64.apk)| | :heavy_check_mark: | a5851d8e | [#4](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21633/4/) | 2024-11-19 13:14:29 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-130448-a5851d-pr21633-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241119-130448-a5851d-pr21633-arm64-v8a.apk)| | | | | | | | | | :heavy_check_mark: | bf2892a4 | [#5](https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-21633/5/) | 2024-11-19 17:44:27 | ~5 min | `tests` | [:page_facing_up:`log`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-173924-bf2892-pr21633-tests.log) | | :heavy_check_mark: | bf2892a4 | [#5](https://ci.status.im/job/status-mobile/job/prs/job/ios/job/PR-21633/5/) | 2024-11-19 17:48:05 | ~8 min | `ios` | [:iphone:`ipa`](https://i.diawi.com/tb6Sjn) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fi.diawi.com%2Ftb6Sjn)| | :heavy_check_mark: | bf2892a4 | [#5](https://ci.status.im/job/status-mobile/job/prs/job/android-e2e/job/PR-21633/5/) | 2024-11-19 17:48:31 | ~9 min | `android-e2e` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-173920-bf2892-pr21633-x86_64.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241119-173920-bf2892-pr21633-x86_64.apk)| | :heavy_check_mark: | bf2892a4 | [#5](https://ci.status.im/job/status-mobile/job/prs/job/android/job/PR-21633/5/) | 2024-11-19 17:49:02 | ~9 min | `android` | [:robot:`apk`](https://status-im-mobile-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-241119-173920-bf2892-pr21633-arm64-v8a.apk) [:calling:](https://chart.apis.google.com/chart?cht=qr&chs=400x400&chld=L%7C%0A1&chl=https%3A%2F%2Fstatus-im-mobile-prs.ams3.cdn.digitaloceanspaces.com%2FStatusIm-Mobile-241119-173920-bf2892-pr21633-arm64-v8a.apk)|
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: aab6c1fe #6 2024-11-20 13:08:22 ~4 min tests :page_facing_up:log
:heavy_check_mark: aab6c1fe #6 2024-11-20 13:12:21 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: aab6c1fe #6 2024-11-20 13:12:42 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: aab6c1fe #6 2024-11-20 13:13:14 ~9 min android :robot:apk :calling:
:heavy_check_mark: 58476a43 #7 2024-11-20 15:01:34 ~5 min tests :page_facing_up:log
:heavy_check_mark: 58476a43 #7 2024-11-20 15:04:23 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 58476a43 #7 2024-11-20 15:05:07 ~8 min android :robot:apk :calling:
:heavy_check_mark: 58476a43 #7 2024-11-20 15:05:11 ~8 min ios :iphone:ipa :calling:
Parveshdhull commented 3 days ago

@status-im/mobile-qa Could you please check if the e2e tests need any adjustments?

status-im-auto commented 3 days ago

0% of end-end tests have passed

Total executed tests: 8
Failed tests: 7
Expected to fail tests: 1
Passed tests: 0
IDs of failed tests: 727230,727231,702745,702742,740490,727229,703133 
IDs of expected to fail tests: 702843

Failed tests (7)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Tap on found: Button
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:279: in create_user self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-later-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    ``` Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:279: in create_user self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-later-button` is not found on the screen after wait_for_visibility_of_element ```

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    ``` Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:315: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-later-button` is not found on the screen after wait_for_visibility_of_element ```

    2. test_wallet_balance_mainnet, id: 740490

    Device 1: Tap on found: Button
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:315: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-later-button` is not found on the screen after wait_for_visibility_of_element ```

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Tap on found: Button
    Device 1: Wait for element `Button` for max 30s and click when it is available

    ``` Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../views/sign_in_view.py:272: in create_user self.enable_notifications_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-button` is not found on the screen after wait_for_visibility_of_element ```

    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    ``` Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../views/sign_in_view.py:315: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-later-button` is not found on the screen after wait_for_visibility_of_element ```

    2. test_wallet_send_eth, id: 727229

    Device 2: Tap on found: Button
    Device 2: Wait for element `Button` for max 30s and click when it is available

    ``` Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../views/sign_in_view.py:315: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`enable-notifications-later-button` is not found on the screen after wait_for_visibility_of_element ```

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    ``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

    pavloburykh commented 2 days ago

    @Parveshdhull thanks for the PR! @yevh-berdnyk could you please adjust e2e tests according to current changes? Thank you!

    status-im-auto commented 2 days ago

    75% of end-end tests have passed

    Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6
    IDs of failed tests: 702745 
    IDs of expected to fail tests: 702843

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    ``` Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) SignInView.create_user() got an unexpected keyword argument 'enable_notifications' ```

    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    ``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

    Passed tests (6)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229
    Parveshdhull commented 2 days ago

    @yevh-berdnyk, Thank you for fixing e2e tests. PR ready to merge? cc @pavloburykh

    status-im-auto commented 2 days ago

    75% of end-end tests have passed

    Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6
    IDs of failed tests: 703133 
    IDs of expected to fail tests: 702843

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button

    ``` critical/chats/test_public_chat_browsing.py:245: in test_restore_multiaccount_with_waku_backup_remove_profile_switch self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) zQ3...dWXh5 was not restored as a contact from waku backup! E zQ3...Vacac was not restored as a contact from waku backup! E admin_open was not restored from waku-backup!! E member_open was not restored from waku-backup!! E admin_closed was not restored from waku-backup!! E member_closed was not restored from waku-backup!! ```

    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    ``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229
    yevh-berdnyk commented 2 days ago

    @yevh-berdnyk, Thank you for fixing e2e tests. PR ready to merge? cc @pavloburykh

    Hi @Parveshdhull, thanks for the PR, it's ready now. E2E test failure is not related