search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

fix(wallet)_: Paraswap contract address #21635

Closed smohamedjavid closed 3 days ago

smohamedjavid commented 4 days ago

Summary

This PR fixes ParaSwap contract address displayed on the setting approval cap for a token. Since, we use ParaSwap v6.2, the contract address is changed.

Before After

Review notes

Since we get the approval contract address in the swap proposal, we take that as higher precedence over the hardcoded value in the constants file.

Platforms

Steps to test

status: ready

status-im-auto commented 4 days ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 19137868 #1 2024-11-18 12:13:22 ~4 min tests :page_facing_up:log
:heavy_check_mark: 19137868 #1 2024-11-18 12:16:56 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 19137868 #1 2024-11-18 12:17:07 ~8 min android :robot:apk :calling:
:heavy_check_mark: 19137868 #1 2024-11-18 12:18:40 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: 96f4b221 #2 2024-11-19 12:17:09 ~5 min tests :page_facing_up:log
:heavy_check_mark: 96f4b221 #2 2024-11-19 12:20:54 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 96f4b221 #2 2024-11-19 12:21:24 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: 96f4b221 #2 2024-11-19 12:21:36 ~9 min android :robot:apk :calling:
pavloburykh commented 4 days ago

@smohamedjavid thanks for the PR. I have been able to check only showing correct contract in app UI (see screenshot below). Swap testing is blocked by https://github.com/status-im/status-mobile/pull/21541 which should be fixed in scope of https://github.com/status-im/status-mobile/pull/21541

photo_2024-11-18 17 15 08

@smohamedjavid I think once this PR is reviewed by devs, we are okay to merge it and then we will proceed with testing swap in scope of #21541

Please, let me know in case there will be any additional changes based on dev review, so I can re-test the PR. Thank you.

status-im-auto commented 4 days ago

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7
IDs of expected to fail tests: 702843

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

smohamedjavid commented 3 days ago

Thanks for checking it @pavloburykh 🙏

There are no changes apart from the ParaSwap contract address displayed in the UI.

I will merged it once I get a approval from Devs.