status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Custom Option Menu for TX Parameters on SEND Flow #21657

Closed vkjr closed 23 hours ago

vkjr commented 1 day ago

fixes #21020

Summary

Implemented menu for customizing transaction parameters on send flow. Figma link

https://github.com/user-attachments/assets/46979639-8ac0-4b91-b21e-6b195eb7ced5

Review notes

This PR adds feature flag, two menus and adjusts settings_item quo component to accept emoji as settings menu item. There is a hardcoded dummy data inside because so far we don't have access to any real data. This is a subject for another issues in epic.

Platforms

Areas that maybe impacted

Functional

Steps to test

status: ready

status-im-auto commented 1 day ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: dbe04ce2 #1 2024-11-20 17:03:06 ~5 min tests :page_facing_up:log
:heavy_check_mark: dbe04ce2 #1 2024-11-20 17:06:11 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: dbe04ce2 #1 2024-11-20 17:06:50 ~9 min android :robot:apk :calling:
:heavy_check_mark: dbe04ce2 #1 2024-11-20 17:14:32 ~16 min ios :iphone:ipa :calling:
:heavy_check_mark: 28fdf476 #2 2024-11-21 15:19:10 ~4 min tests :page_facing_up:log
:heavy_check_mark: 28fdf476 #2 2024-11-21 15:22:34 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 28fdf476 #2 2024-11-21 15:23:09 ~8 min android :robot:apk :calling:
:heavy_check_mark: 28fdf476 #2 2024-11-21 15:23:23 ~8 min ios :iphone:ipa :calling:
pavloburykh commented 1 day ago

Hey @vkjr! Thanks for the PR. Is it ready for testing? If yes, could you please add corresponding label?

Just to confirm: do I understand correctly that PR implements only UI and backend has not been applied yet?

status-im-auto commented 1 day ago

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6
IDs of failed tests: 702745 
IDs of expected to fail tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    ``` Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:310: in create_shared_drivers drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:26: in start_threads returns[k] = await returns[k] /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__ super().__init__( ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__ self.start_session(capabilities) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response raise exception_class(message, screen, stacktrace) Internal Server Error ```

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    ``` Test is not run, e2e blocker ``` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229
    vkjr commented 1 day ago

    @pavloburykh, added the label. Yes, you understand correctly, it is just 2 menus without any functionality tied to them.

    pavloburykh commented 1 day ago

    @pavloburykh, added the label. Yes, you understand correctly, it is just 2 menus without any functionality tied to them.

    Thanks @vkjr! Tested and ready to merge.