search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.89k stars 985 forks source link

Screen cut off when using ERC dEX DApp #3131

Closed chadyj closed 6 years ago

chadyj commented 6 years ago

User Story

As a user, I want to use ERC dEX so that I can trade.

Description

Type: Bug

Summary: When I search for a token I can no longer see half the screen. If I scroll down I only see white

Expected behavior

I expect to see the rest of the screen

Actual behavior

The screen is cut off and I only see white.

img_0533_png

Reproduction

Solution

Summary:

Remove the white overlay to see the screen behind.

Additional Information

cc @lukeautry from ERC Dex

lukeautry commented 6 years ago

That is weird. FWIW (and you can see the intended layout just in mobile mode in Chrome or your desktop browser), the tab bar is a fixed position element stuck to the bottom of the screen - the fact that anything can appear below that is quite strange. Is that white panel rendered in the browser, or does it belong to status?

pablanopete commented 6 years ago

CC @rasom @jeluard @oskarth ^

dmitryn commented 6 years ago

@chadyj i don't have this issue using iOS simulator (iPhone 6) and real android (oneplus 5)

dmitryn commented 6 years ago

Cannot reproduce this on iPhone X in simulator as well.

goranjovic commented 6 years ago

@dmitryn Can't reproduce it either on last nightly with iPhone 6s real device

chadyj commented 6 years ago

I just tried it with the nightly and the problem is still happening. To reproduce make sure you search for a token then scroll.

Tested with real iPhone X.

ercdex-scroll

dmitryn commented 6 years ago

To reproduce make sure you search for a token then scroll.

Still not reproducible for me (i don't have real iPhone X though)

goranjovic commented 6 years ago

Ok I see it now (real 6s)

dmitryn commented 6 years ago

@goranjovic i suggest you to look at this further

flexsurfer commented 6 years ago

@goranjovic as i remember i could reproduce this in chrome so the problem not in status

chadyj commented 6 years ago

I tried to reproduce in Chrome on iOS and it worked as expected.

goranjovic commented 6 years ago

Looks ok in Toshi too. Seems related to keyboard somehow

flexsurfer commented 6 years ago

@goranjovic it reproduced for specific webview size, so if you play with browser window size on a desktop you will reproduce it for sure

flexsurfer commented 6 years ago

imo we can't fix it in status

lukaszfryc commented 6 years ago

The Getting Started screen is also cut off. Someone reproduce it on Android 24, SM-G935F:

@chadyj do you think we should contact the app creators like we do in #3887?

chadyj commented 6 years ago

@lukaszfryc I tested with a few other mobile dapp browsers and they all correctly displayed the page. Seems like the issue is with Status.

Also @lukeautry (commented above) is from ERCDex if you have any questions for the developer.

rachelhamlin commented 6 years ago

Same issue when I try to register for Etherbots. Keyboard opens and a box covers the text input:

chadyj commented 6 years ago

@lukeautry Would you mind grabbing the latest Status build and switch to Mainnet and checkout ERC dEX in Status? There are a few responsive issues.

lukeautry commented 6 years ago

Thanks @chadyj, I'll take a look.

rachelhamlin commented 6 years ago

Still seeing Chad's original keyboard issue in Status, but not other browsers. @jeluard @flexsurfer I think it's our problem.

https://willalways.love/

In this case, the modal is so short that you can't see what's happening in the frame.

ddex

Engrave your love on the blockchain - willalways.love