Null is not an object error is shown when "http:/" as url in Status browser

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum

https://status.app

Mozilla Public License 2.0

3.88k stars 984 forks source link

Null is not an object error is shown when "http:/" as url in Status browser #6291

Closed lukaszfryc closed 5 years ago

lukaszfryc commented 5 years ago

Description

Type: Bug

Summary:

When a user made a mistake and typed "http:/" instead of "http://", the app can't parse the url and error is shown. When closed, everything works fine.

Expected behavior

I'd suggest showing the default error page instead:

Actual behavior

Error when "http:/" or "http:///", etc. url:

Reproduction

Type "http:/google.com" in Status browser

Additional Information

Status version: nightly, 12 Oct
Operating System: all

asemiankevich commented 5 years ago

dupe https://github.com/status-im/status-react/issues/6290

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it as part of the Status-im fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $54,630.48 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 10 months, 3 weeks from now. Please review their action plans below:

1) dhamaniasad has been approved to start work.

I've worked with react native before and I'd like to this on. I could fix it within a day.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by:

@dhamaniasad

@StatusSceptre please take a look at the submitted work:

PR by @dhamaniasad

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$55,283.81 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

⚡️ A tip worth 12.00000 DAI (12.0 USD @ $1.0/DAI) has been granted to @dhamaniasad for this issue from @StatusSceptre. ⚡️

Nice work @dhamaniasad! Your tip has automatically been deposited in the ETH address we have on file.

$56851.33 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

Gitcoin: Grow Open Source
Issue Explorer
The Gitcoin platform connects freelance developers with open bug bounties or online jobs, paid in crypto (ETH). Leverage a global workforce to quickly complete software development and coding jobs.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @dhamaniasad.

Additional Tips for this Bounty:

StatusSceptre tipped 12.0000 DAI worth 12.0 USD to dhamaniasad.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$56,791.33 more funded OSS Work available on the Gitcoin Issue Explorer