search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 987 forks source link

0.9.30 Release #6311

Closed chadyj closed 6 years ago

chadyj commented 6 years ago

This is an issue to list and discuss remaining issues for the 0.9.30 release.

Remaining issues can be viewed with the release tag. https://github.com/status-im/status-react/labels/release

The 0.9.30 release has several improvements for #cryptolife and Devcon.

Using this issue to manage the release as team comms are split between Status and Slack cc @status-im/clojure @rachelhamlin @andytudhope @annadanchenko @lukaszfryc

rachelhamlin commented 6 years ago

Alex looking at #6428 this morning.

On Sun, Oct 21, 2018 at 6:05 PM Igor Mandrigin notifications@github.com wrote:

I'll take a look at (2) tomorrow, Apple still doesn't look at the test builds on weekends, so the earliest review we can get is tomorrow evening (European time) anyway.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/status-react/issues/6311#issuecomment-431681150, or mute the thread https://github.com/notifications/unsubscribe-auth/AOwPY-b2MonPVjutMSedMrdJDefDawVuks5unJtPgaJpZM4Xb8ie .

chadyj commented 6 years ago

@mandrigin If we want this to be ready for the hackathon then when is the absolute latest we should submit to Apple? We are getting really close, and I expect much of the team will be travelling so we should set a hard deadline or we risk being late.

@annadanchenko How did regression testing go?

mandrigin commented 6 years ago

@chadyj we have an older build of 0.9.30 approved (I submitted it yesterday), so we theoretically should get Insta-approvals for the newer builds too. In the meantime, can you post release notes here?

chadyj commented 6 years ago

Thanks Igor.

Release notes are here https://docs.google.com/document/d/1Z0mFlJJkNbRgv6qm80ob5g4PEvsI8cTmbwZpcRPWPho/edit

Google Docs
Release Notes - Ongoing
Process for status releases: Each status release needs a brief 3 - 5 paragraph story to tell about the successes, challenges and features within the release. Work with #core-releases to compare commits to facts of “New & Improved and Bug Fixes” section - Commit differences can be found here and ...
lukaszfryc commented 6 years ago

Re regression testing, we have not done the full regression yet because of open issues. We have 2 open PRs that may introduce regressions in messaging area: https://github.com/status-im/status-react/pull/6466 and https://github.com/status-im/status-react/pull/6448. And https://github.com/status-im/status-react/pull/6388 that may affect transactions. I'll start testing 6466 and 6448 while they are still in review.

@chadyj I think we absolutely need to close them today to submit the new build tomorrow.

jeluard commented 6 years ago

I had to cherry-pick a tiny tiny extension bug: #6463

annadanchenko commented 6 years ago

@jeluard I see you marked it (#6463) with skip-qa and merged directly to release. Can you comment on any tests done by yourself for it? will you check it also in the release build?

jeluard commented 6 years ago

@annadanchenko Yes this fix relates to changes needed to have some specific feature of extension working. Harmless out of the scope of extension. Will validate manually myself.

annadanchenko commented 6 years ago

@annadanchenko How did regression testing go?

@chadyj on yesterday's release build test team completed most of critical and high priority tests and found no more blockers besides known in https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3Arelease

Unfortunately, we are still in progress of fixing 2 issues for duplicated messages after upgrade (#6460, #6438) and an issue to add new networks #6250 that also impacts upgrade. So as soon as they are done, we will need to run regression tests again and it can bring more surprises.

GitHub
status-im/status-react
a free (libre) open source, mobile OS for Ethereum - status-im/status-react
jeluard commented 6 years ago

How mandatory is #6250 ? We must have the new release out for the hackathon or we can't test easily extensions.

annadanchenko commented 6 years ago

How mandatory is #6250 ?

imo, if we can't fix it today we need to drop it to release the rest.

but there are upgrade issue and they are not pretty at all to release with, @janherich any estimates when fixes will be ready?

rachelhamlin commented 6 years ago

I would also vote to drop it in order to get us closer to release (cc @andytudhope)

asemiankevich commented 6 years ago

@chadyj ^

annadanchenko commented 6 years ago

@yenda added https://github.com/status-im/status-react/pull/6478 to the release too. However, I'm not sure how critical it is (described scenario works fine without this PR or steps are wrong in the PR), waiting for Eric to comment

goranjovic commented 6 years ago

regarding #6250 - we can bypass the upgrade decryption problem if we don't include the migration to add two sidechains to the existing accounts. In practice, this would mean that hackaton participants who want to use the sidechains would have to use a new account (but at least they would be able to do that)

wdyt @annadanchenko @andytudhope ?

chadyj commented 6 years ago

regarding #6250 - we can bypass the upgrade decryption problem if we don't include the migration to add two sidechains to the existing accounts. In practice, this would mean that hackaton participants who want to use the sidechains would have to use a new account.

Sounds like a decent trade off to get this release shipped.

goranjovic commented 6 years ago

@chadyj Ok, I'll remove the migrations then.

yenda commented 6 years ago

@goranjovic maybe there is a bug in the migration ?

rachelhamlin commented 6 years ago

So this PR should solve both #6460 + #6438: https://github.com/status-im/status-react/pull/6488

But build process is delaying us, per Ragged Understated Loon. 😕

pablanopete commented 6 years ago

regarding #6250 - we can bypass the upgrade decryption problem if we don't include the migration to add two sidechains to the existing accounts. In practice, this would mean that hackaton participants who want to use the sidechains would have to use a new account (but at least they would be able to do that)

wdyt @annadanchenko @andytudhope ?

also agree this won't be a problem because xDaichain is a brand new side chain so people won't have any tokens in it before the hackathon anyways very likely - creating a new account is a bit of a UX slowdown but also agree to get it in release shipped and since it's blocking old accounts it makes sense.

annadanchenko commented 6 years ago

@rachelhamlin is there anything to be changed in the mobile app for ENS usernames? like linking to the Dapp url on mainnet ?

chadyj commented 6 years ago

We are 2 days away from the Hackathon and so really have to wrap up this release today. People will also be traveling so availability will be limited.

The de-duplication work is being done so thanks @janherich @rasom for making it a priority. Please yell out if you are blocked or can't get this done in a few hours.

@goranjovic do you expect to wrap up the sidechain issue this morning, or should we drop it from the release?

@rachelhamlin @jeluard are things all set for extensions? When is ENS launching on Mainnet? AFAIK it still needs to be tested in the release

@j-zerah @kimjf Are you all set with release notes?

If things aren't in a good spot by 12CEST we should jump on a call and discuss how to proceed.

annadanchenko commented 6 years ago

@goranjovic @chadyj despite known non-critical issues I propose to merge #6388 and document known issues in release notes. see them in https://github.com/status-im/status-react/pull/6388#issuecomment-432549313

jeluard commented 6 years ago

@chadyj Everything is ready for extensions.

Let's :ship: :ship: :ship:

rachelhamlin commented 6 years ago

@chadyj @annadanchenko nothing to change in status-react. The entry point on the profile screen links to names.statusnet.eth.

The ENS contract still needs to be deployed to mainnet, which will require a change with the names.statusnet.eth ENS resolver, but nothing more to do in Status to support this.

We're aiming to have this done today, so it will happen ahead of the release.

rachelhamlin commented 6 years ago

We've tested the ENS DApp thoroughly on Ropsten and as soon @bgits or @3esmit deploys the contract to mainnet, will test there as well.

chadyj commented 6 years ago

⚡️⚡️⚡️All the outstanding release issues have been closed. ⚡️⚡️⚡️

The release build can be downloaded from jenkins for testing.

However the Testflight upload failed complaining about Invalid username and password combination. @mandrigin @jakubgs Can you please take a look?

chadyj commented 6 years ago

Roman fixed (thanks) the Fastlane issue and build 11274 is ready for testing in Testflight. ⚡️⚡️⚡️

kimjf commented 6 years ago

I am traveling today but should be able to help with the release tomorrow. Do we need an intro written for the notes? If we do could you highlight in the notes the key updates to call out?

Sent from my iPhone

On Oct 24, 2018, at 9:16 AM, Chad Jackson notifications@github.com wrote:

We are 2 days away from the Hackathon and so really have to wrap up this release today. People will also be traveling so availability will be limited.

The de-duplication work is being done so thanks @janherich @rasom for making it a priority. Please yell out if you are blocked or can't get this done in a few hours.

@goranjovic do you expect to wrap up the sidechain issue this morning, or should we drop it from the release?

@rachelhamlin @jeluard are things all set for extensions? When is ENS launching on Mainnet? AFAIK it still needs to be tested in the release

@j-zerah @kimjf Are you all set with release notes?

If things aren't in a good spot by 12CEST we should jump on a call and discuss how to proceed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

chadyj commented 6 years ago

I noticed one issue in the TF version where messages are not ordered properly. Older messages are shown before newer messages.

screen shot 2018-10-24 at 2 26 44 pm

@yenda Fixed a related ordering issue today on desktop. Same cause?

jeluard commented 6 years ago

@chadyj I have this issues for days. Probably not a recent regression.

rachelhamlin commented 6 years ago

@kimjf no stress, already written! Coordinating with Jonny on the posts.

annadanchenko commented 6 years ago

test team is very close to complete regression testing on the last release build. So far, no blocking issues found. In ~30 min we expect to complete testing and potentially we are OK to release.

@chadyj when do we want to release it? On TestFlight it's 11274 in 0.9.30. For Android: https://ci.status.im/job/status-react/job/release/job/release%252F0.9.30/24/artifact/pkg/StatusIm-181024-080818-46d265-release.apk cc @mandrigin

yenda commented 6 years ago

@chadyj it is not the same cause because the cause on desktop wasn't related to mobile at all. I think it is because the timestamp of chats isn't based on last message but time when the last message was received in the chat, so when receiving messages from inbox the chats are ordered based on when the last message was received from there

chadyj commented 6 years ago

Nice one @annadanchenko and team!

If everything looks good let's shoot for 10am CEST tomorrow! 🌮

We will use 11274 in TF and 11274 in Google Play currently in the internal test track.

rachelhamlin commented 6 years ago

Didn't realize this was already approved by Apple! Nice job, everyone!

Might be preferable to release later in the day, from a product perspective.

We just deployed the ENS contract to mainnet, and Barry is making a few last changes to the DApp before we can test on mainnet.

Once 0.9.30 is live & announced, people will know they can register names. @asemiankevich and I will test the DApp as soon as the latest is deployed today, but more buffer might be good. We were initially thinking we'd announce around 9 ET tomorrow.

@j-zerah thoughts from a marketing perspective? There is a blog post for both 0.9.30 and for ENS, and Blonde is also making a PR about ENS.

rachelhamlin commented 6 years ago

Update: ENS DApp works well in my run-through of each core flow, but there's one tiny and fatal issue. The price is wrong below the fold on the first screen.

This requires attention from both @bgits and @3esmit to re-deploy the DApp, once fixed. After speaking with @j-zerah, think it makes sense to target 3 pm CEST to release 0.9.30.

@annadanchenko @chadyj

annadanchenko commented 6 years ago

@chadyj @mandrigin 11274 build is in Ready to Submit state that looks like it wasn't submitted to review. Can you send it to review if it's so, please?

annadanchenko commented 6 years ago

nevermind, just did it myself and got approval right after this

mandrigin commented 6 years ago

done. approved. "testing"

rachelhamlin commented 6 years ago

Latest version of the ENS DApp is deployed, now we need Ricardo to update the ENS URI to contain the new IPFS hash.

He should be landing in Prague soon, but I think we should push the release back one more hour to 4 PM CEST to be safe.

chadyj commented 6 years ago

0.9.30 is released!

https://our.status.im/v0-9-30-release-extensions-ens-security/

Our Status
v0.9.30 Release – Extensions, ENS Names, and more!
The Status Hackathon - #CryptoLife is taking place in Prague this weekend (October 26 - 28), so this release goes out to the developers who will be hacking with us both at the event and around the world.ExtensionsBuilding a DApp? You can now extend Status functionality to make your