status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Add local chats contacts data in chat command payloads #6594

Closed jeluard closed 5 years ago

jeluard commented 5 years ago

User Story

As a developer, I want to have access to a contacts available in current chat. This data will be part of the previews and on-send/on-receive events. In 1-1 chat, get access to the recipient details via :contact In private group-chats, get access to all group members via :contacts In public chat, does nothing.

Description

Type: Feature

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to it as part of the Status.im fund.

StatusSceptre commented 5 years ago

@cr2fx thanks for applying, it would be best if you joined here https://get.status.im/chat/public/status-core to discuss further!

Join the public chat: #status-core in Status
gitcoinbot commented 5 years ago

@cr2fx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@cr2fx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@cr2fx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

cr2fx commented 5 years ago

@gitcoinbot - Working on it, will make the PR soon

gitcoinbot commented 5 years ago

@cr2fx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@cr2fx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@cr2fx due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@cr2fx due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

cr2fx commented 5 years ago

Error while building status

> Could not find com.android.tools:common:25.2.3
jeluard commented 5 years ago

@cr2fx Can you provide some more context?

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 5 days, 3 hours from now. Please review their action plans below:

1) tbenr has applied to start work _(Funders only: approve worker | reject worker)_.

it should be enough to access app db and extends data exposed to the required events\views

Learn more on the Gitcoin Issue Details page.

jeluard commented 5 years ago

@andytudhope Could we approve @tbenr ?

jeluard commented 5 years ago

@tbenr This might be helpful to get access to contact details:

(map status-im.contact.db/public-key->address 
     @(re-frame.core/subscribe 
       [:get-in [:chats chat-id :contacts]]))
gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month, 3 weeks ago. Please review their action plans below:

1) tbenr has been approved to start work.

it should be enough to access app db and extends data exposed to the required events\views

Learn more on the Gitcoin Issue Details page.

StatusSceptre commented 5 years ago

@tbenr You are good to go now!

tbenr commented 5 years ago

@StatusSceptre starting now, note that the work is expired..

jeluard commented 5 years ago

@tbenr It will be taken care of, no worries

tbenr commented 5 years ago

@jeluard i'm working on this and I have a question: is it currently possible to define a hook command for :group-chats? I'm trying to do that but...

jeluard commented 5 years ago

Not right now but here is the change needed to make it possible: https://github.com/status-im/status-react/pull/7092/files#diff-3007be229fd9697dce9c25de8412cca1R118

GitHub
[Fixes #7052 and #7037] Improved extensions ethereum support by jeluard · Pull Request #7092 · status-im/status-react
fixes #7052 and #7037 Summary: Refactored ethereum events to introduce on-sucess and on-failure events. Fixed some low-hanging fruits. status: ready
gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 120.0 DAI (120.0 USD @ $1.0/DAI) has been submitted by:

  1. @tbenr

@StatusSceptre please take a look at the submitted work:


gitcoinbot commented 5 years ago
Above And Beyond ⚡️ A *Above And Beyond* Kudos has been sent to @tbenr for this issue from @StatusSceptre. ⚡️ Nice work @tbenr! Your Kudos has automatically been sent in the ETH address we have on file.
gitcoinbot commented 5 years ago

⚡️ A tip worth 120.00000 DAI (120.0 USD @ $1.0/DAI) has been granted to @tbenr for this issue from @StatusSceptre. ⚡️

Nice work @tbenr! Your tip has automatically been deposited in the ETH address we have on file.

Gitcoin: Grow Open Source
Issue Explorer
The Gitcoin platform connects freelance developers with open bug bounties or online jobs, paid in crypto (ETH). Leverage a global workforce to quickly complete software development and coding jobs.
gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @tbenr.

Additional Tips for this Bounty:


StatusSceptre commented 5 years ago

Great work on this one @tbenr !

tbenr commented 5 years ago

@StatusSceptre thank you!!