search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 987 forks source link

Incoming token transactions are shown as outgoing ETH transactions in wallet -> transactions history #6835

Closed yevh-berdnyk closed 5 years ago

yevh-berdnyk commented 5 years ago

Description

Type: Bug

Summary: For token transactions data of normal transactions is shown and expected data is not. For example: Here is incoming STT transaction: https://ropsten.etherscan.io/tx/0x89dd2d0937d7e4f4101d5ceabbf71e67c61b21a161746504533511e68a39f40d - 1000 STT received But in the wallet it's shown as outgoing transaction with value 0 ETH

Expected behavior

Correct value, to and from addresses are shown for token transactions

Actual behavior

Incoming token transactions are shown in the history as outgoing ETH transactions.

Reproduction

Additional Information

Status version: 0.9.3 (12790); node 27700aa2 (Nov 21 nightly build) Operating System: Android, iOS

Ropsten Transaction 0x89dd2d0937d7e4f4101d5ceabbf71e67c61b21a161746504533511e68a39f40d
Ropsten (ETH) detailed transaction info for 0x89dd2d0937d7e4f4101d5ceabbf71e67c61b21a161746504533511e68a39f40d
Ropsten Accounts, Address And Contracts
The Ethereum BlockChain Explorer, API and Analytics Platform
yevh-berdnyk commented 5 years ago

@goranjovic please confirm that this was not intentionally changed

asemiankevich commented 5 years ago

@bhauman i believe that could be caused by the token history fix, could you please double check?

goranjovic commented 5 years ago

This is a token minting transaction (e.g. from Status Test Dapp or by directly sending 0 ETH to contract). So, the bug here is a missing token transfer event (or not merged with the tx).

Worth checking if token transfers show up for incoming tokens which are sent by another user. Also worth checking if mainnet works ok, i.e. maybe the bug affects only ropsten

asemiankevich commented 5 years ago

@goranjovic is it something we can fix someday soon? want to have our nightly e2e in green, this is the only blocker for them now

mandrigin commented 5 years ago

@asemiankevich @goranjovic what do you think of making it a reasonable size bounty?

churik commented 5 years ago

It is OK for new transactions in https://github.com/status-im/status-react/pull/8005 (last days), but still the case for older transactions.

sometimes it is still reproducible after relogin or just after recover account (can be related to https://github.com/status-im/status-react/issues/7329)

churik commented 5 years ago

closed in https://github.com/status-im/status-react/pull/8228