search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

0.9.32 mobile release #6891

Closed lukaszfryc closed 5 years ago

lukaszfryc commented 5 years ago

We will use this issue to manage 0.9.32 release.

open issues and PRs for release: https://github.com/status-im/status-react/labels/release

cammellos commented 5 years ago

@Serhy thanks, cherry-picked

asemiankevich commented 5 years ago

TBH, I don't see a reason why we should not include #6932 in the release. It contains useful feature for group chats and is all tested. cc @Serhy @cammellos

The reason, in a nutshell, is to follow the plan in what we about to release (the new features and bugfixes we stick to by release branch cut off). It makes sense to include fixes to outstanded regressions, but not really makes sense to include new features (what for to cut off the release branch then?)

@lukaszfryc @cammellos let's cherry-pick #6932 in release/0.9.32, this is the part we were aimed to retest anyway. But lets agree (and keep in release notes) afterwards, the rules we try to follow in relation to similar questions in future. cc @chadyj

@lukaszfryc totally agree with @Serhy here. Also if u are proposing something to be included - make sure averyone impacted is aware. This is the first time i hear about this nice feature to be a part of release. cc @annadanchenko

chadyj commented 5 years ago

@rachelhamlin @j-zerah
There was a comment here about needing Decentraland in the dapp listing by December 10. Is that still required? It needs to be in this release or it won't make the deadline.

j-zerah commented 5 years ago

@chadyj @rachelhamlin - yes if we can add decentraland to the list in this release, it would be much appreciated. We are launching comms for a joint campaign on december 10

chadyj commented 5 years ago

Hey devs! Can anyone help bringing decentraland back? We used to have it and was removed in this PR so you can grab assets and info https://github.com/status-im/status-react/pull/4232/files#diff-3f0aba2b3c8741a870b1cffc6357607dL188

GitHub
[#4218] Removed some DApps by jeluard · Pull Request #4232 · status-im/status-react
fixes #4218 Summary: Removed older DApps status: ready
jeluard commented 5 years ago

@chadyj Find the PR here: https://github.com/status-im/status-react/pull/6992/files

GitHub
Added Decentraland DApp by jeluard · Pull Request #6992 · status-im/status-react
Added Decentraland back Summary: status: ready
flexsurfer commented 5 years ago

cherry picked https://github.com/status-im/status-react/pull/6992

flexsurfer commented 5 years ago

cherry picked https://github.com/status-im/status-react/pull/6971

asemiankevich commented 5 years ago

@chadyj we are waiting for https://github.com/status-im/status-react/pull/6987 to be tested and merged to release branch. Then we can do final testing i guess, since i am not aware of any other commits to be included. What was the agreed deadline for the Asia Roadshow build?

cc @Serhy @churik @annadanchenko @mandrigin @jeluard @rachelhamlin

asemiankevich commented 5 years ago

@jakubgs @rasom @mandrigin https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/ is failing . Please assist

release/0.9.32 [status-react » release] [Jenkins]
jeluard commented 5 years ago

@asemiankevich EthSinpapore hackathon starts on Dec 6.

asemiankevich commented 5 years ago

@mandrigin i believe https://ci.status.im/job/status-react/job/upload_release_ios/ requires the same fix, could you please assist here too?

upload_release_ios [status-react] [Jenkins]
mandrigin commented 5 years ago

the job is fixed and the build is submitted to Apple to be reviewed

annadanchenko commented 5 years ago

hackathon starts on Dec 6.

are you sure @jeluard ? on https://ethsingapore.co/ 7 Dec is a start date and 9:30PM is listed as time when it's officially begins

ETHSingapore Hackathon Dec 7-9, 2018
rachelhamlin commented 5 years ago

@annadanchenko you're right, it's Friday the 7th.

lukaszfryc commented 5 years ago

Looks like group chats are enabled in release builds by default. I think it's not expected as we wanted to keep them under development mode for release builds. @cammellos could you fix it?

It was probably introduced in https://github.com/status-im/status-react/commit/5795ca8d1a58ff3e7efbefa1e4c2f9b509e7e9ec

asemiankevich commented 5 years ago

@lukaszfryc we tested this and this is done intentionally as far as i know. @annadanchenko ?

annadanchenko commented 5 years ago

Looks like group chats are enabled in release builds by default. I think it's not expected as we wanted to keep them under development mode for release builds. @cammellos could you fix it?

It was probably introduced in 5795ca8

I'd rather not touch release anymore unless there are functional issues. Is it so risky to have group chats enabled by default? @chadyj @lukaszfryc @cammellos

lukaszfryc commented 5 years ago

Is it so risky to have group chats enabled by default?

It's not. As Andrea said "with that, the only reason to have them in dev mode would be to warn users that is a beta-feature." (more in https://github.com/status-im/status-react/issues/6882). But having in mind that Status is still kind of beta, I think we can leave them enabled by default.

annadanchenko commented 5 years ago

new release build with https://github.com/status-im/status-react/pull/7014 timed out and another one started: https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/24/

status-react » release » release/0.9.32 #24 [Jenkins]
asemiankevich commented 5 years ago

started https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/26/ - should be fine

status-react » release » release/0.9.32 #26 [Jenkins]
asemiankevich commented 5 years ago

@chadyj any news about apple review?

asemiankevich commented 5 years ago

@chadyj @annadanchenko review passed as i can see in iTunesConnect

annadanchenko commented 5 years ago

submitted new "2018120516" build to Apple review and got Approve, so it's fine on this side and can be pushed to public testing as soon as we are done with final testing on 2018120516 TestFlight build and Android release from https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/26/

status-react » release » release/0.9.32 #26 [Jenkins]
chadyj commented 5 years ago

Nice job everyone! 🎉

I expired the older build so we only have the latest available. I also added the release notes and its ready to go.

@j-zerah @Blockchain-Islander @pablanopete Let's aim to release 3CST/9EST tomorrow. Sound good?

pablanopete commented 5 years ago

Sounds good to me! cc @Blockchain-Islander the blog is ready to go for that time if you're good on social copy as well.

Blockchain-Islander commented 5 years ago

Thanks all! Will get this live at 3pm CST 👍

rasom commented 5 years ago

Hey team, it would be really great to include https://github.com/status-im/status-react/pull/7019/files to the release. There is a tiny chance that without this fix some users which had message duplicates because of issues with message-id calculation BEFORE 0.9.31 still have duplicates in their DB and migrations will not pass without this change. It only checks if the message with a new message-id has been added and removes duplicate. The same way it removes duplicates from user-status entity.

I'm really sorry for making this late update, but as it hasn't been reproduced during testing it was a bit hard to spot this possible issue.

GitHub
[WIP] fix possible user-status duplicate by rasom · Pull Request #7019 · status-im/status-react
status: wip
chadyj commented 5 years ago

Thanks for the fix Roman. Agree we should include this.

asemiankevich commented 5 years ago

@mandrigin @jakubgs can't build release again https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/29/ . Please take a look!

status-react » release » release/0.9.32 #29 [Jenkins]
mandrigin commented 5 years ago

Try again, it looks like saucelabs was down for some reason.

jakubgs commented 5 years ago

Yup: https://status.saucelabs.com/

Sauce Labs Inc Status
Welcome to Sauce Labs Inc's home for real-time and historical data on system performance.
asemiankevich commented 5 years ago

its fine now :thisisfine:

asemiankevich commented 5 years ago

@chadyj could you please expire previous build in TestFlight? I submitted one more with Roman's commit. And also add release notes. Can't find how to do this myself :(

chadyj commented 5 years ago

Expired. Here is the screenshot of what to press on the build page. (not sure about permissions though)

Also remember that if you upload a new build please grab the "what's new" from the old build or release notes.

screen shot 2018-12-06 at 9 36 19 am
asemiankevich commented 5 years ago

@chadyj i dont have rights( thanks for assistance

chadyj commented 5 years ago

Heya are we good with the 2018120610 build? @asemiankevich @annadanchenko We are scheduled to ship in an hour.

annadanchenko commented 5 years ago

@chadyj no blockers found, basic checks went fine

annadanchenko commented 5 years ago

unfortunately, new blocker was found when doing minor checks: https://github.com/status-im/status-react/issues/7027

annadanchenko commented 5 years ago

@chadyj @mandrigin do you want to postpone the release because of #7027 and fix it or we can release with (9999) in ios version?

annadanchenko commented 5 years ago

having another thought on it - only users with diawi access can install ios builds, so typical user will have TestFlight version anyway so might not be a blocker really, unless it can influence future upgrades

chadyj commented 5 years ago

We have the fix merged https://github.com/status-im/status-react/pull/7028 so may as well run a new build.

annadanchenko commented 5 years ago

@chadyj we may but I'm not sure if other changes in upload release job are fine and would rather stay with 9999 as exception for this release. Unless developers will say that 9999 in the version can impact future upgrades cc @mandrigin @rasom @cammellos

chadyj commented 5 years ago

@j-zerah @Blockchain-Islander @pablanopete Apologies for the delay.

There have been some tech issues and we don't have consensus on how to proceed. Hopefully we will have an update within the hour.

annadanchenko commented 5 years ago

@j-zerah @Blockchain-Islander @pablanopete looks like we got consensus and will push the release in 10 minutes from now.

j-zerah commented 5 years ago

ok thank you. Please let us know when comms can go out

annadanchenko commented 5 years ago

@j-zerah @Blockchain-Islander @pablanopete both iOS and Android releases for 0.9.32 are published. Please, send comms cc @chadyj

pablanopete commented 5 years ago

Ok, thanks!

chadyj commented 5 years ago

Comms are out! https://our.status.im/v0-9-32/ https://twitter.com/ethstatus/status/1070710037415428096

Thanks y'all! Seeya next time 🍻

Our Status
v0.9.32 Release - Private Group Chats
Version 0.9.32 Introducing beta support for Private group chats! There is also alpha support of pairing (with development mode on) between mobile and desktop clients for messages and contacts syncing.
Twitter
Status on Twitter
“Version 0.9.32 has been released! Private group chats, device syncing and more are included in this release. Check out the release notes for more details. https://t.co/faPiNDD8EK”
annadanchenko commented 5 years ago

@pablanopete 0.9.32 apk for cn site: http://status-im.ams3.digitaloceanspaces.com/StatusIm-181206-094952-05782d-release.apk