Closed goranjovic closed 5 years ago
All inputs that accept addresses should display a warning if the entered address is not in mixed case or if it is not valid according to eip-55
Do we re-use this error pop-up for invalid address for this case? @goranjovic @denis-sharypin
@rachelhamlin not, really. In the new design, it should be like this. But I can't come up with the good wording for that. "This address is not checksummed" sounds too technical for me.
Could simply say Error in address
?
Maybe take a look and see how other wallets did it? It makes sense to be consistent in wording.
There are three cases:
I checked a few mobile wallets with not checksummed address and none of them checking addresses for that. I got this error once only on myetherwallet.com and the description was like "This address is not checksummed". But I find such description too technical, something that an average user won't get.
Thanks for researching, @denis-sharypin.
I suspect this error state is unlikely anyway. Most people will copy/paste an address.
That said, I suggest sticking to plain English with Error in address
or even Check for typos
.
Do we want this one as a bounty? Please 👍 the issue if this one is to be bountied @rachelhamlin; wasn't sure of the state of it with the current discussions.
@StatusSceptre yes, would be great to put a bounty on. I'll edit the issue to include warning screen and copy. Can we keep @goranjovic tagged in the issue so that he can answer any questions?
No problem @rachelhamlin
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it as part of the Status-im fund.
Thanks @StatusSceptre!
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 10 months, 3 weeks from now. Please review their action plans below:
1) mestorlx has been approved to start work.
I will follow the guidelines here(https://eips.ethereum.org/EIPS/eip-55) to implement the method to validate signatures. Once its done I will add it to one field to test and validate. After there is agreement from Status it will be extended to the rest of the fields. Should take a couple of days.
Learn more on the Gitcoin Issue Details page.
Approved @mestorlx
@StatusSceptre great thanks! I am working on this already. However I am having issues compiling the iOS test. Any Gitter or slack channel where I can ask about it?
@mestorlx here ya go! Check out this public chat on the Status app: https://get.status.im/chat/public/status-core
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by:
@StatusSceptre please take a look at the submitted work:
⚡️ A tip worth 8.00000 DAI (8.0 USD @ $1.0/DAI) has been granted to @mestorlx for this issue from @StatusSceptre. ⚡️
Nice work @mestorlx! Your tip has automatically been deposited in the ETH address we have on file.
Gitcoin: Grow Open SourceThe Gitcoin platform connects freelance developers with open bug bounties or online jobs, paid in crypto (ETH). Leverage a global workforce to quickly complete software development and coding jobs.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @mestorlx.
Additional Tips for this Bounty:
Problem
Users should be protected against accidental typos in Ethereum addresses
https://eips.ethereum.org/EIPS/eip-55
Implementation
All screens that expose addresses should render it in mixed case according to eip-55 All inputs that accept addresses should display a warning if the entered address is not in mixed case or if it is not valid according to eip-55
Update: Warning screen UI Warning copy should read
Error in address
.Future Steps
Steps which should be taken after this issue has been resolved.