search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.86k stars 984 forks source link

Expose ethereum logs details in an extension manipulable way #7075

Closed jeluard closed 5 years ago

jeluard commented 5 years ago

User Story

As a developer, I want to have an easy access to both data and logs property from logs events in an easy to consume way. It could be exposed in a new events property.

jeluard commented 5 years ago

Hey @speedyFixer ! Nice to see some great progress!

Re. adding indexed yes please definitely! Re. key names: same as in contract would probably be the most convenient

gitcoinbot commented 5 years ago

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

StatusSceptre commented 5 years ago

@speedyFixer Great job so far, have snoozed the gitcoin bot warnings while you're working on this.

speedyFixer commented 5 years ago

@StatusSceptre @jeluard thanks!

gitcoinbot commented 5 years ago

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

speedyFixer commented 5 years ago

Hi, just an update about the work:

Decoded DATA is almost done, after that, I will do the topics decode, I will do some code cleaning and finally I will do the PR.

decoded

ropsten_decode

Thanks for your patience :+1:

jeluard commented 5 years ago

@speedyFixer Thanks for the update!

gitcoinbot commented 5 years ago

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

speedyFixer commented 5 years ago

Hello @jeluard , could you help me with any clue about how could I run tests on my local environment? I was try clj -R:test build.clj test without luck because java.lang.NullPointerException is showed while it compiles build.clj

This issue is almost done, I'm testing it.

jeluard commented 5 years ago

@speedyFixer You can run tests with lein test-cljs

speedyFixer commented 5 years ago

Thanks @jeluard I was able to run tests with clj -R:test build.clj test test, I just tested lein test-cljs but doesn't work:

Updating hook: pre-commit Retrieving lein-doo/lein-doo/0.1.9/lein-doo-0.1.9.pom from clojars Retrieving org/clojure/clojurescript/1.9.229/clojurescript-1.9.229.pom from central Retrieving lein-doo/lein-doo/0.1.9/lein-doo-0.1.9.jar from clojars Retrieving org/clojure/clojurescript/1.9.89/clojurescript-1.9.89.pom from central Retrieving re-frame/re-frame/0.9.3/re-frame-0.9.3.pom from clojars WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 76 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 76 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 76 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 167 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 167 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 167 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 228 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 228 test/cljs/status_im/test/pairing/core.cljs WARNING: Use of undeclared Var status-im.utils.config/pairing-enabled? at line 228 test/cljs/status_im/test/pairing/core.cljs

;; ====================================================================== ;; Testing with Node:

Error: Cannot find module 'hi-base32' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15) at Module._load (internal/modules/cjs/loader.js:506:25) at Function.hookedLoader [as _load] (/Developments/status-react/target/test/test.js:14:10) at Module.require (internal/modules/cjs/loader.js:636:17) at require (internal/modules/cjs/helpers.js:20:18) at Object. (/Developments/status-react/target/test/status_im/js_dependencies.cljs:12:26) at Module._compile (internal/modules/cjs/loader.js:688:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10) at Module.load (internal/modules/cjs/loader.js:598:32) at tryModuleLoad (internal/modules/cjs/loader.js:537:12) Error encountered performing task 'doo' with profile(s): 'test' Subprocess failed

Seems like that hi-base32 is missing in the dev dependencies?

jeluard commented 5 years ago

@speedyFixer Looks like we will have to fox that! If you can run your test anyway, LGTM

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 120.0 DAI (120.0 USD @ $1.0/DAI) has been submitted by:

  1. @speedyfixer

@StatusSceptre please take a look at the submitted work:

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @speedyFixer.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @speedyFixer.