hesterbruikman commented 5 years ago

Problem

When people participate in a Status chat, other users can access and view their wallet address.

Wallet address becomes accessible through:

Profile view
Command features in chat
Send transaction > Select recipient (regardless of whether the viewing user has been added as a contact.

People are currently not informed that their wallet address is exposed when they participate in a chat.

While work is in progress to make it such that the wallet address is not exposed to anyone other than trusted users, we want to implement a message to inform people about who can see their wallet address.

Implementation

A contextual warning in wallet that limits unnecessary exposure, but informs at the moment exposure of the wallet address has potential for adverse effects.

Bottom sheet is trigger by tapping on [Receive] in the Wallet tab, before copying or sharing the wallet address.
Bottom sheet component; component is dismissable by pulling it down or tapping outside of it.
Bottom sheet includes a 'don't show me again' checkbox. When user ticks this box, warning should no longer come up.
Bottom sheet should come up for all users, irrespective of whether they already have value in their Wallet.

For behavior see: https://www.figma.com/proto/M6BzDsCWdrHZxzy7RUzoCCLz/Warnings-and-alerts?node-id=17%3A313&viewport=8%2C-200%2C0.7&scaling=scale-down

Wallet address warning

Acceptance Criteria

Use of bottom sheet component with content and behaviour as specified above. https://github.com/status-im/status-components

Notes

Future Steps

Copy will need to be updated, removing the first sentence: "People you talk to on Status can see this code"

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $58,398.79 more funded OSS Work available on the Gitcoin Issue Explorer

StatusSceptre commented 5 years ago

@bitsikka this might be an easy one for you based on previous work. Thoughts?

bitsikka commented 5 years ago

@StatusSceptre just saw this now(i have all notifications turned off everywhere) :smile:

yes, this is right up my alley - going for it

@hesterbruikman, @StatusSceptre,

having worked on #7715 recently, I also noticed that usage of bottom-sheet implementation/design is inconsistent/not-updated-according-to-figma-design in other places like the chat-actions bottom sheets. The issue(s) is/are not yet captured here in github either 🤔

bitsikka commented 5 years ago

@StatusSceptre just saw this now(i have all notifications turned off everywhere)

Just updated my notifications settings to not miss this again

Thanks for proactively considering me on this issue. Please feel free to mention me again in the future and I will respond in a timely manner

bitsikka commented 5 years ago

For behavior see: https://www.figma.com/proto/M6BzDsCWdrHZxzy7RUzoCCLz/Warnings-and-alerts?node-id=17%3A313&viewport=8%2C-200%2C0.7&scaling=scale-down

@hesterbruikman figma design is not loading for me. I tried viewing it in chrome and firefox

hesterbruikman commented 5 years ago

@bitsikka so sorry, need to check my notification settings as well:S

Can you try this Figma link please? https://www.figma.com/file/M6BzDsCWdrHZxzy7RUzoCCLz/Warnings-and-alerts?node-id=79%3A277

On inconsistency of the bottom sheet. I'm afraid we indeed have some legacy implementations. Do you recall a specific modal that didn't meet requirements? Also, note that there are 2 variations of the bottom sheet, a dismissable one and a non-dismissable one. Recognizable by the little grey handle at the top of the sheet.

cc @errorists as I'm out for a few days,

bitsikka commented 5 years ago

@hesterbruikman new figma link works! thanks!

regarding inconsistent bottom sheet I meant this(in figma):

Vs

this(current develop)

for all 3 types of chat(but there may be more)

errorists commented 5 years ago

hey @bitsikka you're right, any instance of the native activity sheet (the one on the second of your screenshots) should be updated to the bottom sheet design. I like to think we're in a transition phase and gradually exchanging them. We will create appropriate bounties to address those. cc @hesterbruikman

gitcoinbot commented 5 years ago

@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

bitsikka commented 5 years ago

@gitcoinbot yes I am working on it

gitcoinbot commented 5 years ago

@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

bitsikka commented 5 years ago

@gitcoinbot yes still on it. Will make PR soon

gitcoinbot commented 5 years ago

@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@bitsikka due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

bitsikka commented 5 years ago

@gitcoinbot sorry for dragging this for too long, I have no excuse. Please bare with me. This is a simple PR and I will submit it within a day from now.

gitcoinbot commented 5 years ago

@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!