flexsurfer commented 5 years ago

Currently, the transaction overview shows only the token being transacted. It should also include the user's currency.

Expected behavior

Actual behavior

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $149,534.19 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 4 weeks, 1 day from now. Please review their action plans below:

1) vic-en has applied to start work _(Funders only: approve worker | reject worker)_.

Hi, I will study the code carefully and integrate any free or opensource currency conversion api to ensure it display user currency as requested. I await your approval so I can begin work immediately.

Learn more on the Gitcoin Issue Details page.

rachelhamlin commented 5 years ago

You're approved @vic-en! Welcome. @yenda @flexsurfer which api do we use for currency conversion elsewhere?

yenda commented 5 years ago

There is no need to interact with the API, there is already a :prices subscription to get the prices

gitcoinbot commented 5 years ago

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

vic-en commented 5 years ago

I've started work on this bounty. I think @yenda has a point. There wouldn't be a need to use external currency conversion api. I'll just figure out how to access that interface.

vic-en commented 5 years ago

Hi, just to update. I've also made great progress towards showing the user currency. I'm still familiarizing myself with the code and layout to ensure nothing more or less happens than showing user's currency alone.

rachelhamlin commented 5 years ago

That's great @vic-en! Should we expect a PR this week?

gitcoinbot commented 5 years ago

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

vic-en commented 5 years ago

That's great @vic-en! Should we expect a PR this week?

yes, this weekend I broke my installation by accident but I fixed it today so I'll test the code again

gitcoinbot commented 5 years ago

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

vic-en commented 5 years ago

@rachelhamlin , so sorry I'm replying late. I've having problem with my development workspace lately. I have lost several important data and this project is also part of it and I'm afraid I may not be able to continue this project soon to complete the bounty. However, I'm ready to give all possible info and will be stating the necessary to complete the bounty to whoever will take it up soon.

The steps to complete the bounty is as follow:

The major view file to make the user currency appear is here
The lines in the above file to effect the converted currency are majorly between lines 216 and 260
Also cryptocompare.com currency conversion API is already part of the project and should be included at the beginning of the file like this

[status-im.utils.prices :as prices]

and called like this

prices/get-prices [from to mainnet? on-success on-error chaos-mode?]

In addition, a money formatting library has been coded also and should also be added like this

[status-im.utils.money :as money]

and called like this

money/fiat-amount-value [amount-str from to prices]

In order not to waste more of time, I would stop work on this bounty on your confirmation if you want to re-assign to another developer. I'll keep checking back on the issue to know if anymore help is needed. Also, I wouldn't mind a little tip.

acolytec3 commented 5 years ago

If @vic-en is stepping back, @rachelhamlin, I'd be interested in picking this one up (since it looks like there weren't any other applicants on it). I've also applied to work on #8443 and this one is a precursor to that so would be happy to do both at once. Let me know!

rachelhamlin commented 5 years ago

Hey guys! Thanks for your patience, I'm just getting back into the swing after our offsite.

@vic-en - really sorry about your troubles. This is helpful work to show. I'll see if I can send you a tip when the time comes to pay this one out. I've unassigned you from the bounty in the meantime. Once you get back up and running, ping me somewhere if you'd like to try again + we can find work for you :)

@acolytec3 - appreciate you following up as well! Can you apply for this one on Gitcoin now? As it's worth the same amount as #8443 & several other returning contributors applied there, it'd be great to have you cover this one!

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 8 months, 1 week ago. Please review their action plans below:

1) acolytec3 has been approved to start work.

I would like add this feature following the guidelines laid out in the github issue 2) elegant651 has applied to start work _(Funders only: approve worker | reject worker)_.

I already get used to status-react, want to get involved in this contribution.

Learn more on the Gitcoin Issue Details page.

yenda commented 5 years ago

@acolytec3 note that the comment above is not correct, you should not call cryptocompare for this bounty. This bounty is much simpler than that. If you are not familiar with subscriptions check re-frame GitHub repo they have great documentation, as well as the subs.cljs namespace where most of the subscriptions are declared, including :prices

What you need to do is simply to make a subscription that uses prices as input and use it in the view

acolytec3 commented 5 years ago

@yenda, thanks! I've got a start of things following your suggestion and will hopefully get a working PR in the next day or two. Just still navigating through the forest of tooling so my productivity is still kind of slow.

acolytec3 commented 5 years ago

@rachelhamlin Just checking in on this. I've applied on gitcoin and haven't officially been accepted to work on this yet though my PR is close to done (pending final review from the devs/designers).

rachelhamlin commented 5 years ago

Hey! So sorry about that @acolytec3. I just approved you 😬We're a bit bottlenecked, but thank you so much for the PR.

acolytec3 commented 5 years ago

Thanks! Just submitted my PR on gitcoin. Just waiting on the other two reviewers to provide feedback or approve.

rachelhamlin commented 5 years ago

Excellent, nicely done @acolytec3! I'll try to give it a whirl myself tomorrow and get payment to you ASAP (we typically wait for PRs to be merged but recognize there is a long wait for that right now).

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by:

@acolytec3

@StatusSceptre please take a look at the submitted work:

PR by @acolytec3

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$151,999.84 more funded OSS Work available on the Gitcoin Issue Explorer

acolytec3 commented 5 years ago

Thanks! Are there any other issues coming up for bounties soon? Would love to take a crack at another one if so.

rachelhamlin commented 5 years ago

@acolytec3 awesome! Unfurling of URLs in chat can wait; I just saw you applied on Gitcoin. I haven't bountied any of these yet, but they're blockers for our v1 release, do any of them catch your eye?

https://github.com/status-im/status-react/issues/8938 https://github.com/status-im/status-react/issues/8960 https://github.com/status-im/status-react/issues/8818

Also - I can pay for this bounty once the devs review once more. Both on holiday today. Will ask for a pass tomorrow. :)

acolytec3 commented 5 years ago

I'll take #8938! I think I have an instinct on how to turn it around and therefore more manageable for me since I'm relatively new to this CLJS game, ;-).

I'm still kind of interested in trying out that unfurling one so might go ahead and work on it some once I get 8938 done since it presents a good opportunity to learn more about how interoperability with Javascript works (since I've never touched that).

On Thu, Oct 3, 2019, 11:46 AM Rachel Hamlin notifications@github.com wrote:

@acolytec3 https://github.com/acolytec3 awesome! Unfurling of URLs in chat can wait; I just saw you applied on Gitcoin. I haven't bountied any of these yet, but they're blockers for our v1 release, do any of them catch your eye?

8938 https://github.com/status-im/status-react/issues/8938

8960 https://github.com/status-im/status-react/issues/8960

8818 https://github.com/status-im/status-react/issues/8818

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/status-react/issues/8027?email_source=notifications&email_token=AEENFXEZV36PMETJ3TRNUWLQMYHT3A5CNFSM4HICHFY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAIUPTQ#issuecomment-538003406, or mute the thread https://github.com/notifications/unsubscribe-auth/AEENFXFPZYTCKRVPU4QOAUDQMYHT3ANCNFSM4HICHFYQ .

rachelhamlin commented 5 years ago

🙌 Bounty processing! I invited you @acolytec3.

acolytec3 commented 5 years ago

@rachelhamlin PR was just merged :-)

acolytec3 commented 5 years ago

@rachelhamlin I got a notification from gitcoin about a tip but it referenced a bounty I didn't worked on. Was it supposed to be for this one or #8938?

rachelhamlin commented 5 years ago

Whoops, not quite sure how I managed that. I underpaid you as well @acolytec3. It was for this one.

I tipped you 60 DAI on #8135 and meant to 80 DAI pay for this one, #8027.

I'll send over another 20 on this one and close it out on Gitcoin. Sorry about that!

rachelhamlin commented 5 years ago

Jokes. I can't pay out less than the full 80 DAI for this one.

I'll add 20 DAI as tip for your work on #8938 instead @acolytec3.

acolytec3 commented 5 years ago

@rachelhamlin No worries! Was just a little confused when I saw the linked issue on the gitcoin notification.

Given that I've finished #8938, would love to keep working if there are other issues that need immediate attention. Anything I can look at?

On Mon, Oct 7, 2019, 8:04 AM Rachel Hamlin notifications@github.com wrote:

Whoops, not quite sure how I managed that. I underpaid you as well @acolytec3 https://github.com/acolytec3. It was for this one.

I tipped you 60 DAI on #8135 https://github.com/status-im/status-react/issues/8135 and meant to 80 DAI pay for this one, #8027 https://github.com/status-im/status-react/issues/8027.

I'll send over another 20 on this one and close it out on Gitcoin. Sorry about that!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/status-react/issues/8027?email_source=notifications&email_token=AEENFXGLOCS743D4YNHWSH3QNMQV5A5CNFSM4HICHFY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQCGII#issuecomment-538977057, or mute the thread https://github.com/notifications/unsubscribe-auth/AEENFXCOMZIXPH4BHKKQJ73QNMQV5ANCNFSM4HICHFYQ .

rachelhamlin commented 5 years ago

Indeed there are more in the queue for you, @acolytec3!

What about one of these bugs?

Wallet balance refresh not working properly Recent stickers not populating

acolytec3 commented 5 years ago

8951 sounds cool. I'll take it!

On Mon, Oct 7, 2019, 8:16 AM Rachel Hamlin notifications@github.com wrote:

Indeed there are more in the queue for you, @acolytec3 https://github.com/acolytec3!

What about one of these bugs?

Wallet balance refresh not working properly https://github.com/status-im/status-react/issues/8951 Recent stickers not populating https://github.com/status-im/status-react/issues/8937

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/status-react/issues/8027?email_source=notifications&email_token=AEENFXARKJYMAF6QRNQDLXLQNMSCFA5CNFSM4HICHFY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQDIJI#issuecomment-538981413, or mute the thread https://github.com/notifications/unsubscribe-auth/AEENFXA6HCZEZV5DVQXQAMDQNMSCFANCNFSM4HICHFYQ .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 80.0 SAI (80.0 USD @ $1.0/SAI) attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin Chat
$144,037.12 more funded OSS Work available on the Gitcoin Issue Explorer

status-im / status-mobile

[Wallet] Show values in the user's currency #8027

8938 https://github.com/status-im/status-react/issues/8938

8960 https://github.com/status-im/status-react/issues/8960

8818 https://github.com/status-im/status-react/issues/8818

8951 sounds cool. I'll take it!