status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 987 forks source link

Hide keycard options for Android as well (v1) #9740

Closed rachelhamlin closed 4 years ago

rachelhamlin commented 4 years ago

Problem

Keycards are being wiped on recovery—we are therefore not going to sell any until we have resolved the issue.

This issue is to hide any Keycard related options in the onboarding & recovery flows on Android. Keycard options are already hidden on iOS.

Implementation

Remove these options from Android v1 build:

image

Acceptance Criteria

Option to recovery with Keycard no longer appears on Android. Key storage selection no longer appears on Android during onboarding.

Notes

cc @guylouis @gravityblast @andremedeiros

Future Steps

Resolve erased keycard issue w/ help of NXP.

guylouis commented 4 years ago

cc @bitgamma too

rachelhamlin commented 4 years ago

Evidently the current release build does not include any references to Keycard, so if we're basing v1 off a release (?), then we don't need to change anything here. Just need to be aware of this.

cc @churik @Serhy