status-im / status-protocol-go

Status Protocol implementation in Go
Mozilla Public License 2.0
0 stars 1 forks source link

Integrate status-protocol-go with status-react #2

Closed cammellos closed 5 years ago

cammellos commented 5 years ago

As a developer I would like to have status-protocol-go to be integrated with status-react So that any change to the StatusProtocol is isolated and other clients can re-use this library

Description

This library should be integrated with status-react via status-go.

For it to be working without any change in status-react:

Changes in API in status-react/status-go can be made to accommodate the integration, as long as functionalities are maintained.

Backward compatibility between the resulting status-go version and status-react is not needed (i.e is fine if the version of status-go that includes this library is not compatible with current status-react, if that's the case care must be taken not to merge too early and have develop of status-go not compatible with develop of status-react, in order to avoid potentially blocking other developers, if incompatible I would delay merging until successfully QAed).

Acceptance criteria

oskarth commented 5 years ago

@adambabik is there a corresponding issue on status-react for this? Is the idea that we shouldn't need one beyond minor updating status-go version and QA? "For it to be working without any change in status-react"

What's the rough ETA/effort on this one?

adambabik commented 5 years ago

@oskarth it is now as I finished work in status-go and status-protocol-go repos. Please check out https://github.com/status-im/status-react/issues/8604.

In terms of ETA, it's a matter of testing now and maybe doing some small tweaks.