status-im / status-protocol-go

Status Protocol implementation in Go
Mozilla Public License 2.0
0 stars 1 forks source link

Move sorting/stream/datemark of messages logic in status-protocol-go #6

Open cammellos opened 5 years ago

cammellos commented 5 years ago

As a developer I want to have all the sorting logic/datemark implemented in status-protocol-go So I can benefit from the performance of go

Description

This task involves moving the sorting/datemark etc logic to this library , which involves stuff like https://github.com/status-im/status-react/blob/5a020744260aebce8c1e0a3f05be4f1584bc8492/src/status_im/chat/models/message.cljs#L55 or https://github.com/status-im/status-react/blob/develop/src/status_im/chat/models/loading.cljs

This will likely have a large impact on status-react codebase.

The aim is to consolidate logic in this library, performance optimization are in scope and overall we believe it should improve performances, but no performance degradation should result because of this.

rachelhamlin commented 5 years ago

@cammellos I have this in Wrike as a v1 - release task, but not actually sure why. Is it relevant for release?

cammellos commented 5 years ago

@rachelhamlin no, it can easily be done post v1