Failed websocket connections are retried instantly

status-im / status-web

Packages for building web applications in the Status ecosystem.

https://status-components.vercel.app

Mozilla Public License 2.0

82 stars 35 forks source link

Failed websocket connections are retried instantly #320

Open Menduist opened 1 year ago

Menduist commented 1 year ago

Which will probably lead to some nice DDoSes To test it out, you can for instance specify a wrong PeerId (the thing after /p2p) in packages/status-js/src/consts/peers.ts It will lead to this:

(not sure if it's actually coming from status-web or js-waku) Some exponential backoff would nice to avoid frying the servers if a significant amount of nodes start to do this :smiley:

felicio commented 1 year ago

Notes

status-web now fails, reflects ui and stops js-waku with the following https://github.com/status-im/status-web/commit/c925efbaf58177cdec5a2e316fcf1a387d6d7389#commitcomment-93540312
so only js-waku@^0.30.0 or rather libp2p dialer is causing these uncontrolled retries when offline/unreachable, however this behavior might have been moved to js-waku in its latest version (cc @fryorcraken)

fryorcraken commented 1 year ago

Thanks, will keep in mind when investigating https://github.com/waku-org/js-waku/issues/751 which may be fix thanks to an auto-dial from libp2p.