Closed marcelines closed 1 month ago
Latest commit: 34855e144da90d584d00d626fa2fe83e3eb45460
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@marcelines is attempting to deploy a commit to the Status Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
status-components | ✅ Ready (Inspect) | Visit Preview | 💬 2 unresolved ✅ 4 resolved |
Oct 14, 2024 9:13am |
This should be implemented using https://www.radix-ui.com/primitives/docs/components/toggle-group#examples, don't you think?
Next time you update the composition (like adding context), think it through. Adding React Context eliminates the need for these cloning gymnastics.
Next time you update the composition (like adding context), think it through. Adding React Context eliminates the need for these cloning gymnastics.
You're absolutely right. I'm tired and i missed it. But i still need it to be cloned so that i can pass the ref to have the animated selector.
:grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
---|---|---|---|---|---|---|
:x: | c99d7d9c | #2 | 2024-10-17 12:41:28 | ~14 sec | chrome |
:page_facing_up:log |
:x: | 34855e14 | #3 | 2024-10-17 13:04:29 | ~14 sec | chrome |
:page_facing_up:log |
I see you've already checked the changes @marcelines 👍.
I made a few cosmetic changes to align with other components in the library. Reordering, renaming from "tab" to "segment"...
I removed the distinction between icon
and emoji
because we a) currently don't have a defined approach to handling emojis and b) we don't support them in <Tabs />
either. However, I hope that when the time comes, we can reuse the icon
prop for emojis (e.g. `icon={
Added hook to consume context to this component and <Tabs />
.
Changes
components
package along with its story.