search

status-im / status-web

Packages for building web applications in the Status ecosystem.
https://status-components.vercel.app
Mozilla Public License 2.0
82 stars 36 forks source link

add transparent background option to `<Avatar type="account" />` #617

Open jkbktl opened 1 month ago

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 56646ccc5c9a04890b2b42b9bb413fc0b732d6c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @status-im/components | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 1:16pm
prichodko commented 1 month ago

Can you point me to Figma where this is reflected?

jkbktl commented 1 month ago

Can you point me to Figma where this is reflected?

https://www.figma.com/design/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=483-19407&m=dev

prichodko commented 1 month ago

This is "Design System for Mobile". 🤔

jkbktl commented 1 month ago

This is "Design System for Mobile". 🤔

Omg, didn't notice that, it's linked from Status Portfolio Figma though. https://www.figma.com/design/8IuYR751lsXg1F8bu8Cj8B/Status-Portfolio?node-id=1539-302342&m=dev

marcelines commented 1 month ago

Looking at figma, we can see that the design team are using a component from mobile's library. image image

And then looking at the use case in the design file, we can see a very different implementation. Will the design implement this variant of the component in our library? The selected state is different from ours. Line should be dashed. image image

jkbktl commented 1 month ago

Looking at figma, we can see that the design team are using a component from mobile's library.

We expect that design will put this in order so our design system (for web) is in use. It doesn't necessarily have to be dashed, it might be solid, it depends on type of wallet (watched vs connected) as visible here in Figma, should be also visible in portfolio PR on different addresses.

This PR will be closed I guess.