search

status-im / status.im-old

Main Status.im webpage.
http://status.im/
2 stars 1 forks source link

Form should be in Spanish no matter what #42

Closed noman-land closed 6 years ago

noman-land commented 6 years ago

Forcing Spanish translation on all country codes HubSpot supports.

@LaloGarza, I believe this should fix the form translation issue you reported. Unfortunately there's no way to test until it's live so I'll let you know.

cc/ @oskarth

oskarth commented 6 years ago

I don't understand this PR @noman-land. Why do we want to force Spanish everywhere?

noman-land commented 6 years ago

For posterity:

The HubSpot form unfortunately does not translate itself based on browser locale, so it always displays in English. Since this is a Spanish page (/es.html), anyone looking at it should see a Spanish translation, no matter what their browser locale says.

In the future, when the translation is done more smartly, there should be a different translation for each locale (and only one HTML page).