search

status-im / swarms

Swarm Home. New, completed and in-progress features for Status
92 stars 31 forks source link

Add lead contributor to idea registry #214 #221

Closed debragail closed 6 years ago

debragail commented 6 years ago

*I dont know what add misising data is for 2. task

Added the column for contributor Added column title as Contributor

status-github-bot[bot] commented 6 years ago

Hey @debragail, thanks for making your first pull request in ideas! :heart:

oskarth commented 6 years ago

Thanks for you contribution @debragail!

Missing data are all the ideas under https://ideas.status.im/all that don't have a lead contributor in their yaml. If you run bundle exec jekyll serve this should be visible, and then data is listed as Lead contributor in the idea file.

For example: https://raw.githubusercontent.com/status-im/ideas/master/ideas/58-mainnet.md doesn't have a lead-contributor field in yaml, but you can see further down it should be adambabik. This one does have it though: https://raw.githubusercontent.com/status-im/ideas/master/ideas/101-extensions.md

oskarth commented 6 years ago

Essentially it's a simple way of knowing who the contact person is for that particular swarm, similar to 'Author field' at http://eips.ethereum.org/all

debragail commented 6 years ago

what is different between: ‘contributor’ and ‘lead-contributor’?

oskarth commented 6 years ago

@debragail contributors is a list of all the people who committed to the swarm, 'lead-contributor' is the swarm lead, the person responsible for end to end execution of the swarm. The latter is always one person. See https://github.com/status-im/ideas/blob/master/MANUAL.md for more

GitHub
status-im/ideas
ideas - Swarm Home. New, completed and in-progress features for Status
oskarth commented 6 years ago

@debragail Ping on this one

debragail commented 6 years ago

I ask because I was going to create lead-contributor and wasn’t sure if it should be a type of contributor structurally

debragail commented 6 years ago

I see now. I fixed it.

debragail commented 6 years ago

Following up on this

oskarth commented 6 years ago

Hm, I still don't see any missing data having been added? https://github.com/status-im/ideas/pull/221/files I added this separately in another PR, but not for all ideas I believe

GitHub
Add lead contributor to idea registry #214 by debragail · Pull Request #221 · status-im/ideas
*I dont know what add misising data is for 2. task Added the column for contributor Added column title as Contributor
oskarth commented 6 years ago

I'll go ahead and merge this one as partial solution, it should show us which data is missing more precisely