search

staudenmeir / laravel-merged-relations

Merged Laravel Eloquent relationships
MIT License
178 stars 11 forks source link

Fixed namespace in README.md #21

Closed lee-van-oetz closed 3 months ago

lee-van-oetz commented 3 months ago

Staudenmeir\LaravelMergedRelations\Facades\Schema doesn't seem to have ::drop() method and text points to views package as well. I assume Staudenmeir\LaravelMigrationViews\Facades\Schema was intended.

staudenmeir commented 3 months ago

Hi @lee-van-oetz, Thanks for your PR. The code is actually correct: The facade inherits methods like dropView() from the laravel-migration-views package. IDEs could originally show these inherited methods but don't anymore after I had to refactor the facade. I'll document these methods again.

The code snippet uses the Staudenmeir\LaravelMergedRelations\Facades\Schema facade to show that you don't need to import two different Schema facades in your migration.

lee-van-oetz commented 3 months ago

Hi @staudenmeir, you're absolutely correct, IDE was lying to me :). Thanks for explaining!