stav121 / i3wm-themer

🎨 Theme collection manager for i3-wm
MIT License
2.22k stars 246 forks source link

polybar adn i3 can't detect colors #8

Closed canopeerus closed 6 years ago

canopeerus commented 7 years ago

Hi, I just followed your instructions form the readme by first running with the -c arguemtn which successfully added the required stuff to the start of both files. However running the script to set a theme fails and a lot of actions list as failed in the terminal. The rofi colorscheme and gtk theme seem to work fine but polybar,i3 urxvt fail to set new colors. Here's the output on running the script.

[*] i3wmthemer script started

[] You have entered theming mode. [] Located the theme directory. [+] Fonts are set up successfully [+] GTK Theme migration completed successfully. [+] Icon migration completed successfully. [] Located .extend.Xresources file in theme the directory. [] Located ~/.Xresources file. [-] Failed to apply change: Overwrite .background: . [-] Failed to apply change: Overwrite .foreground: . [-] Failed to apply change: Overwrite .cursorColor: . [-] Failed to apply change: Overwrite URxvt.background . [-] Failed to apply change: Overwrite URxvtforeground . [-] Failed to apply change: Overwrite URxvtcursorColor . [-] Failed to apply change: Overwrite URxvt.font . [-] Failed to apply change: Overwrite .color0: . [-] Failed to apply change: Overwrite .color1: . [-] Failed to apply change: Overwrite .color2: . [-] Failed to apply change: Overwrite .color3: . [-] Failed to apply change: Overwrite .color4: . [-] Failed to apply change: Overwrite .color5: . [-] Failed to apply change: Overwrite .color6: . [-] Failed to apply change: Overwrite .color7: . [-] Failed to apply change: Overwrite .color8: . [-] Failed to apply change: Overwrite .color9: . [-] Failed to apply change: Overwrite .color10: . [-] Failed to apply change: Overwrite .color11: . [-] Failed to apply change: Overwrite .color12: . [-] Failed to apply change: Overwrite .color13: . [-] Failed to apply change: Overwrite .color14: . [-] Failed to apply change: Overwrite .color15: . [+] Applied change: Overwrite rofi.color-enabled: [+] Applied change: Overwrite rofi.color-window: [+] Applied change: Overwrite rofi.color-normal: [+] Applied change: Overwrite rofi.color-active: [+] Applied change: Overwrite rofi.color-urgent: [+] Applied change: Overwrite rofi.font: [] Finished editing ~/.extend.Xresources file. [] Executing 'xrdb ~/.Xresources' command. [] Success! [+] Located .i3/config file in the theme directory. [+] Located ~/.config/i3/config file. [-] Failed to apply change: Overwrite new_window . [-] Failed to apply change: Overwrite new_float . [-] Failed to apply change: Overwrite new_window . [-] Failed to apply change: Overwrite client.background . [+] Applied change: Overwrite client.focused . [+] Applied change: Overwrite client.unfocused . [+] Applied change: Overwrite client.focused_inactive . [+] Applied change: Overwrite client.urgent . [-] Failed to apply change: Overwrite client.placeholder . [+] Located .config/polybar/config file in the theme directory. [+] Located ~/.config/polybar/config file. [+] Applied change: Overwrite bottom . [+] Applied change: Overwrite height . [+] Applied change: Overwrite width . [-] Failed to apply change: Overwrite offset-x . [-] Failed to apply change: Overwrite offset-y . [-] Failed to apply change: Overwrite fixed-center . [+] Applied change: Overwrite line-size . [-] Failed to apply change: Overwrite line-color . [-] Failed to apply change: Overwrite border-size . [-] Failed to apply change: Overwrite border-color . [+] Applied change: Overwrite padding-left . [+] Applied change: Overwrite padding-right . [+] Applied change: Overwrite module-margin-left . [+] Applied change: Overwrite module-margin-right . [-] Failed to apply change: Overwrite tray-position . [-] Failed to apply change: Overwrite tray-padding . [-] Failed to apply change: Overwrite tray-transparent . [-] Failed to apply change: Overwrite tray-offset-x . [-] Failed to apply change: Overwrite tray-offset-y . [-] Failed to apply change: Overwrite tray-maxsize . [-] Failed to apply change: Overwrite tray-detached . [-] Failed to apply change: Overwrite tray-background . [+] Applied change: Overwrite wm-restack . [+] Applied change: Overwrite background . [+] Applied change: Overwrite foreground . [+] Applied change: Overwrite ;override-redirect [-] Failed to apply change: Overwrite label-unfocused-background . [-] Failed to apply change: Overwrite label-unfocused-foreground . [-] Failed to apply change: Overwrite label-unfocused-underline . [-] Failed to apply change: Overwrite label-focused-background . [-] Failed to apply change: Overwrite label-focused-foreground . [-] Failed to apply change: Overwrite label-focused-underline . [-] Failed to apply change: Overwrite label-mode-background . [-] Failed to apply change: Overwrite label-visible-background . [-] Failed to apply change: Overwrite label-visible-foreground . [-] Failed to apply change: Overwrite label-visible-underline . [-] Failed to apply change: Overwrite label-urgent-background . [-] Failed to apply change: Overwrite label-urgent-foreground . [-] Failed to apply change: Overwrite label-urgent-underline . [+] Applied change: Overwrite line-size . [-] Failed to apply change: Overwrite line-color . [-] Failed to apply change: Overwrite border-size . [-] Failed to apply change: Overwrite border-color . [+] Located .config/polybar/config file in the theme directory. [-] Failed to locate ~/.dmenurc in your configuration [+] Located .config/compton.config file in the theme directory. [-] Failed to locate ~/.config/compton.conf in your configuration [+] Wallpaper set successfully [] Restarting i3wm... [] Success! [!] Almost done, please use your appearance manager to set the wallpaper and GTK/Icon themes

[*] i3wmthemer finished



AdrienBenduc commented 7 years ago

Hello canopeerus, I think I have exactly the same issue. I've just followed the steps one by one (from an ubuntu server 16.04).

romulomourao commented 7 years ago

same issue for me

durdo commented 7 years ago

Any update on this? I am having the same problem.

stav121 commented 7 years ago

Hello guys and sorry for the very late response, I am extremely busy those past months and didn't have the time to take a look at the problem.

I know that the script has a few issues but I would still recommend that you install the themes in the manual way (by hand, simple copy-paste) if you are having issues with the script.

For now, the only thing that I have to say, is that the configuration files must kinda match in "style" with the themes that I provide. For example you must have your .Xresources colours in the " .colorx: " and not in the " colorx: " format if you want the script to make changes. Also about the polybar issues, (like everything in the script ) the script only REPLACES existing lines in the configuration files , it does not add new lines when you run it to apply the themes. For example if you are missing the line " wm-restack " , the script will not add it at all.

After I'm done with my university thesis I will spend the time to rewrite the whole script and make it work every time, but for now I'm too busy and I'm sorry for that.

Have a good time guys, Stavros

stav121 commented 7 years ago

Also, forgot to mention that if you wish to use the script you could try to template your configuration files in a way similar to those: https://github.com/unix121/i3wm-themer/tree/master/templated_themes/ , just pick a random theme and try to compare the dotfiles to yours. Once they are templated in a similar way the script should actually work. But still, as I said I will work on a brand new script after I find the time to.

durdo commented 7 years ago

Hello @unix121,

I think you shouldn't close issues you did not solve.

In this issue, for example, I can try to provide a new option in the "i3wmthemer" that copy the theme instead of replacing it. Something along the lines of:

// g - stands for "Generate", but it can be anything else you'd like ./i3wmthemer -g {THEME}

Once a functionality like this is in place you can truly say that the issue does not exist.

In any case, I'll try to solve my problem locally and once it is working I can pull changes to you branch.

Best regards, Eduardo.

stav121 commented 7 years ago

The issue will be re-opened as you requested.

If you find a solution just create a pull request , and I will check it out and probably merge it.

There is an alternative (not recommended tho) to use the old script which copies the entire configuration into your system but is not recommended because it will change your keybinding to my and might mess up your system.

But anyways, I'd be glad if you can find the bug on your own and just merge it.

Best regards, Stavros

stav121 commented 6 years ago

Hello guys,

The whole repository has been reworked, so I'm closing this issue for now. In case you meet any new issues then please open a new Issue thread that is more up-to-date.