search

stavalfi / jstream

Represent graphs, differently https://stavalfi.github.io/jstream/
2 stars 0 forks source link

suggesting a workaround for loops #21

Closed yinonc closed 5 years ago

yinonc commented 5 years ago

@stavalfi What do you think?

stavalfi commented 5 years ago

Thanks for the pull request.

This project isn't complete even with minimal capabilities. The function you modified has bugs and designed incorrectly so I was going to rewrite it anyway.

I will rewrite and include your suggestion. it's much more readable that way.

I haven't created tests yet because I'm not sure exactly what I want and while writing more code I'm redesigning the purpose my parser. That's bad practice but I don't have one more person to show him my design and have him to find things I didn't think of yet so it's the best I got.