search

stavro / arc

:paperclip: Flexible file upload and attachment library for Elixir
1.16k stars 210 forks source link

Update HTTPoison to v1.2 #262

Closed edouardmenayde closed 5 years ago

edouardmenayde commented 5 years ago

I just went ahead and updated the dependency and it tests still do pass locally. It clearly needs some expert eyes because I do not know the code coverage of the project.

Should solve #240 (It's closed but the issue is still here).

pedep commented 5 years ago

I've had a play around with the httpoison 1.3 source, and i see no issue with updating. As far as i'm aware, its only used in one place, using simple GETs. Also, im pretty sure ex_aws (and the other deps) does not use httpoison

If i could get you to bump your PR to httpoison 1.3, and update the README too, this get a :+1: from me

mmartinson commented 5 years ago

Since it's only used in one place in a very simple way, what about removing the HTTPoison dependency entirely in favour of hackney?

Why force users into a specific dependency version that's not needed? In my experience, resolving strict versioning requirements between multiple dependencies is a major pain point for a maturing application, and HTTPoison versioning is one of the prime offenders.

Seems like it would be a completely transparent change, as you're already taking hackney config options directly.

https://github.com/ex-aws/ex_aws/blob/master/mix.exs#L37

stavro commented 5 years ago

Removed and replaced with Hackney instead