search

stayallive / wp-sentry

A (unofficial) WordPress plugin reporting PHP and JavaScript errors to Sentry.
https://wordpress.org/plugins/wp-sentry-integration/
MIT License
320 stars 48 forks source link

Fix deprecated whitelistUrls & blacklistUrls #139

Closed dr5hn closed 2 years ago

dr5hn commented 2 years ago

First of all, Thanks for this amazing package. 🙇🏼‍♂️ I would like to bring your attention to one deprecated public option.

From v7.x onwards blacklistUrls and whitelistUrls are deprecated.

Screenshot 2022-08-12 at 1 22 53 PM

Ref. to latest v7.10.0 sentry-javascript app.js https://github.com/getsentry/sentry-javascript/blob/5a3ed510ca5fc74efd6bc42f1569adb696619f86/packages/browser/examples/app.js#L39-L42

Ref. PR https://github.com/getsentry/sentry-javascript/pull/2671/files

Edit: If you want, I can add backward compatibility code, so no one has to worry about upgrading the package. Please let me know. Or You've to release a new major version.

stayallive commented 2 years ago

No worries, I have plans for a major release dropping the ES5 bundles and this will go great with that! Thanks 🙏

dr5hn commented 2 years ago

@stayallive Is there any ETA I can expect? As I want to use these options.

stayallive commented 2 years ago

No, sorry, don't have an ETA. As soon as I find the time I will make the release including this PR.

Since it requires a major release and I have another feature to include I can't rush this unless I want to release multiple major releases in a short time.

For the time being you can rollback to the plugin bundling the JS SDK lower than 7 or apply your patches manually.

Hope you can understand 👍

stayallive commented 2 years ago

Fixed in: https://github.com/stayallive/wp-sentry/releases/tag/v6.0.0

dr5hn commented 2 years ago

@stayallive Thanks so much for quick turnaround 👍🏼