search

staylor / react-helmet-async

Thread-safe Helmet for React 16+ and friends
Apache License 2.0
2.11k stars 154 forks source link

React 17 support #109

Closed apepper closed 3 years ago

apepper commented 3 years ago

react-helmet-async currently supports react 16:

https://github.com/staylor/react-helmet-async/blob/5c708c1554cfac6e7384484eb9c544e9709cd54c/package.json#L57-L60

Please also add support for React 17.

mtmacdonald commented 3 years ago

Also requesting this please!

tobiasfrei commented 3 years ago

up

Saeeed-B commented 3 years ago

Please Meage that

basvandriel commented 3 years ago

After closing #119 the error still occurs when trying to install this on a React 17 app. 

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: pck-test@0.1.0
npm ERR! Found: react-dom@17.0.1
npm ERR! node_modules/react-dom
npm ERR!   react-dom@"^17.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react-dom@"^16.6.0" from react-helmet-async@1.0.8
npm ERR! node_modules/react-helmet-async
npm ERR!   react-helmet-async@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/bas/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/bas/.npm/_logs/2021-03-03T08_55_32_962Z-debug.log

Can this be re-opened? Also, when using --force when installing the package, the peer dependencies are listed as below:

  "peerDependencies": {
    "react": "^16.6.0 || ^17",
    "react-dom": "^16.6.0"
  },