search

staylor7 / rare-diseases

Catalog of Rare Diseases
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Draft code for sunburst migration [DO NOT MERGE] #11

Closed SallyXue-0114 closed 6 months ago

SallyXue-0114 commented 7 months ago

sunburst feature + chakra playback in JavaScript!

SallyXue-0114 commented 7 months ago

[like] Xue, Sally reacted to your message:

From: Quinn Ouyang @.> Sent: Tuesday, February 6, 2024 4:24:37 PM To: staylor7/rare-diseases @.> Cc: Xue, Sally @.>; Author @.> Subject: Re: [staylor7/rare-diseases] Sunburst js (PR #11)

@quinnouyang commented on this pull request.

Mostly things to address after migrating, but to think about now

On csv2json.jshttps://urldefense.com/v3/__https://github.com/staylor7/rare-diseases/pull/11*discussion_r1480132393__;Iw!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRlLyooWN$:

Fine for now, but for the sake of modularity let's not hard-code the chakra and cateogry together (fullName) and the tooltip (label).

In script.jshttps://urldefense.com/v3/__https://github.com/staylor7/rare-diseases/pull/11*discussion_r1480160616__;Iw!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRpyOTbQV$:

  • let diseaseData = []; // This will store the parsed CSV data
  • // Function to load and parse the CSV
  • function loadDiseaseData() {
  • d3.csv("/public/seq.d3.csv").then((data) => {
  • diseaseData = data;
  • });
  • }
  • // Call the function to load the data
  • loadDiseaseData();

Unless I misunderstood, I'd rather not rely on the CSV just for row numbers to identify which audio file to play. We can encode this mapping in the JSON instead.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/staylor7/rare-diseases/pull/11*pullrequestreview-1865717826__;Iw!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRvmz8u0X$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AWFHGP4M2ZF5TSZRETKTP4TYSJKMLAVCNFSM6AAAAABCV5VDBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRVG4YTOOBSGY__;!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRoX7-Gtz$. You are receiving this because you authored the thread.Message ID: @.***>

staylor7 commented 7 months ago

OMG, I still need to make the time indexes, my apologies! I can have that by tomorrow, sorry!

Stephen Taylor Professor of Music University of Illinois at Urbana-Champaign co-director, Illinois Modern Ensemble www.stephenandrewtaylor.net 217 333-3712 office

On Feb 6, 2024, at 2:19 PM, SallyXue-0114 @.***> wrote:

[like] Xue, Sally reacted to your message:

From: Quinn Ouyang @.> Sent: Tuesday, February 6, 2024 4:24:37 PM To: staylor7/rare-diseases @.> Cc: Xue, Sally @.>; Author @.> Subject: Re: [staylor7/rare-diseases] Sunburst js (PR #11)

@quinnouyang commented on this pull request.

Mostly things to address after migrating, but to think about now

On csv2json.jshttps://urldefense.com/v3/__https://github.com/staylor7/rare-diseases/pull/11*discussion_r1480132393__;Iw!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRlLyooWN$:

Fine for now, but for the sake of modularity let's not hard-code the chakra and cateogry together (fullName) and the tooltip (label).

In script.jshttps://urldefense.com/v3/__https://github.com/staylor7/rare-diseases/pull/11*discussion_r1480160616__;Iw!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRpyOTbQV$:

  • let diseaseData = []; // This will store the parsed CSV data
  • // Function to load and parse the CSV
  • function loadDiseaseData() {
  • d3.csv("/public/seq.d3.csv").then((data) => {
  • diseaseData = data;
  • });
  • }
  • // Call the function to load the data
  • loadDiseaseData();

Unless I misunderstood, I'd rather not rely on the CSV just for row numbers to identify which audio file to play. We can encode this mapping in the JSON instead.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/staylor7/rare-diseases/pull/11*pullrequestreview-1865717826__;Iw!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRvmz8u0X$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AWFHGP4M2ZF5TSZRETKTP4TYSJKMLAVCNFSM6AAAAABCV5VDBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRVG4YTOOBSGY__;!!DZ3fjg!-R5rZH-w4pq1PPS68t_g_JWzolkY9OLpM44NQTWFM0J7orDCkUuJ74fw5b5EkW5Wx3Y0jgktfaqa7JgLppdCRoX7-Gtz$. You are receiving this because you authored the thread.Message ID: @.***> — Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/pull/11#issuecomment-1930685527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKKGP4EYWLDSM3RAW33YSKF4LAVCNFSM6AAAAABCV5VDBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQGY4DKNJSG4. You are receiving this because your review was requested.

quinnouyang commented 7 months ago

@staylor7 Ah no rush, I haven't even gotten to that part yet. Plenty of work to do here!