search

staylor7 / rare-diseases

Catalog of Rare Diseases
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Improve popup UI, add favicons, update colors, and other design tweaks #27

Closed quinnouyang closed 6 months ago

quinnouyang commented 6 months ago

Title. See staging site for commit https://github.com/staylor7/rare-diseases/commit/7f111414016da73731b35476e5ffbcef15c41656 (note playback is broken, pending fixes in https://github.com/staylor7/rare-diseases/pull/32)

staylor7 commented 6 months ago

Favicon is great! And for responsive design you should do whatever you think best.

quinnouyang commented 6 months ago

Reminder to self: redo favicon once new colors are in:)

staylor7 commented 6 months ago

Here are the right colors finally!

ritu #bebada indu #fcaea4 vasu #81b2d2 rudra #fcbc73 veda #b3dd69 aditya #fdd8eb dishi #d9d9d9 bana #bc80bd bhrama #d5eecf netra #ffed6f agni #93d6ca rishi #ffd9b3

On Mar 14, 2024, at 10:07 AM, Quinn Ouyang @.***> wrote:

Reminder to self: redo favicon once new colors are in:) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.Message ID: @.***>

SallyXue-0114 commented 6 months ago

I basically combine the new features in main (pop up window, viola, etc) and the design in this branch (favicon, responsive). So although it still shows conflict, it's technically the latest and full version? You can pull the new changes and please lmk if there's any details I forget. If everything's fine I think there's a thing called branch overwrite or smth?

quinnouyang commented 6 months ago

@SallyXue-0114 Done! See staging site for commit https://github.com/staylor7/rare-diseases/pull/27/commits/7f111414016da73731b35476e5ffbcef15c41656 (note playback is broken, pending fixes in #32)

SallyXue-0114 commented 6 months ago

@SallyXue-0114 Done! See staging site for commit 7f11141 (note playback is broken, pending fixes in #32)

looks cool! I'm experiencing this error even after I refresh: "The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page. https://goo.gl/7K7WLu". I assume this is the issue in #32?

quinnouyang commented 6 months ago

Yah (though I haven't merged the two branches so I can't be certain, but pretty sure #32 handles that). UI should be untouched by this issue