search

staylor7 / rare-diseases

Catalog of Rare Diseases
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

On-click disease information popups, crossfading, and updated hierarchy.json #28

Closed SallyXue-0114 closed 8 months ago

SallyXue-0114 commented 8 months ago
quinnouyang commented 8 months ago

When a user reclicks a chakra, do we want to replay (and fade-in/out) its sound or just ignore the event and continue looping?

For disease audio, I would opt for replaying. (With overlap? Right now it's single-state only so it could clip.)

staylor7 commented 8 months ago

If the use re-clicks a chakra, I think it would be nice if it could ignore that click and continue playing its sound. But for the disease, if a user reclicks it should play again if possible.

On Mar 14, 2024, at 8:17 AM, Quinn Ouyang @.***> wrote:

When a user reclicks a chakra, do we want to replay (and fade-in/out) its sound or just ignore the event and continue looping?

For disease audio, I would opt for replaying. (With overlap? Right now it's single-state only so it could clip.)

— Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/pull/28#issuecomment-1997699255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKKHZGR5ATUGIDVBRQ3YYG5RFAVCNFSM6AAAAABEUVPUGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXGY4TSMRVGU. You are receiving this because your review was requested.

quinnouyang commented 8 months ago

Will ignore chakra re-clicks and continue looping. For diseases, should the new audio reset or overlap the previous? (and should it depend on whether the new audio is for the same disease?)