search

staylor7 / rare-diseases

Catalog of Rare Diseases
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Missing vasu chakra sound #29

Closed quinnouyang closed 6 months ago

quinnouyang commented 6 months ago

There's only 11 in assets/chakra D:

quinnouyang commented 6 months ago

@staylor7 Can you upload this into assets/chakra?

staylor7 commented 6 months ago

I think that the vasu category is so small that I decided not to make a background sound - so for that one, we should just keep playing whatever sound is already playing. I hope that’s OK!

On Mar 15, 2024, at 2:16 PM, Quinn Ouyang @.***> wrote:

@staylor7 https://github.com/staylor7 Can you upload this into assets/chakra?

— Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/issues/29#issuecomment-2000449922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKJONCKYLRBVFVKWOF3YYNQLFAVCNFSM6AAAAABEWPZSGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBQGQ2DSOJSGI. You are receiving this because you were mentioned.

quinnouyang commented 6 months ago

Gotcha, we'll make the exception

quinnouyang commented 6 months ago

Though what happens when the first chakra the user clicks is vasu...is silence OK?

staylor7 commented 6 months ago

Good question! Since Vasu is very tiny I think it’s OK. On Mar 16, 2024, at 12:41 AM, Quinn Ouyang @.***> wrote: Though what happens when the first chakra the user clicks is vasu...is silence OK?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

quinnouyang commented 6 months ago

Cool, fix is pending on commit https://github.com/staylor7/rare-diseases/pull/32/commits/3b110c26a4a5aa5550ce55b2b8c1e5632910efa8

SallyXue-0114 commented 6 months ago

@staylor7 Hi Professor! We find out that vasu is not only missing the chakra sound, but also most of the informations in the csv file:

截屏2024-03-16 下午8 16 49

Should we just exclude vasu in this case?

staylor7 commented 6 months ago

I think it might be a category without any diseases in it! Yes, let’s leave it out if that’s easier.

On Mar 16, 2024, at 6:18 PM, SallyXue-0114 @.***> wrote:

@staylor7 https://github.com/staylor7 Hi Professor! We find out that vasu is not only missing the chakra sound, but also most of the informations in the csv file: 2024-03-16.8.16.49.png (view on web) https://github.com/staylor7/rare-diseases/assets/92959551/96c26772-c81c-4862-9a42-9e6b817c3f0c Can we just exclude vasu in this case?

— Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/issues/29#issuecomment-2002227485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKO3AOWEUGNOCWFEIGDYYTVMTAVCNFSM6AAAAABEWPZSGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGIZDONBYGU. You are receiving this because you were mentioned.