staylor7 / rare-diseases

Catalog of Rare Diseases
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Fix breaking playback issues (asset loading, paths) and improve build configs #32

Closed quinnouyang closed 6 months ago

quinnouyang commented 6 months ago

See staging site for commit https://github.com/staylor7/rare-diseases/pull/32/commits/197a4879f0ab932097efba79750ba9c0b97b64d2

quinnouyang commented 6 months ago

@SallyXue-0114 See this staging site on Cloudflare as of commit https://github.com/staylor7/rare-diseases/pull/32/commits/62e0ea4cf8f5d991881495b8c2414b97ad932bf9

staylor7 commented 6 months ago

Staging site looks great! I have one question on the background chakra sounds. Before they loop back to the beginning, they fade out, then restart. Is it possible to have the chakra sounds loop without any silence in between?

On Mar 16, 2024, at 5:15 PM, Quinn Ouyang @.***> wrote:

@SallyXue-0114 https://github.com/SallyXue-0114 See this staging site https://3199f75b.rare-test.pages.dev/ on Cloudflare as of commit 62e0ea4 https://github.com/staylor7/rare-diseases/commit/62e0ea4cf8f5d991881495b8c2414b97ad932bf9 — Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/pull/32#issuecomment-2002199534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKNCCVC6ALJLQLCFXXLYYTOCZAVCNFSM6AAAAABEY6WQHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGE4TSNJTGQ. You are receiving this because you are subscribed to this thread.

SallyXue-0114 commented 6 months ago

@SallyXue-0114 See this staging site on Cloudflare as of commit 62e0ea4

The link works perfectly on my end👍 no delay or loading problems.

quinnouyang commented 6 months ago

@staylor7 We're relying on the built-in loop property, which doesn't seem to allow for customizations such as crossfading. We'll need to build our own, issue in #31

quinnouyang commented 6 months ago

See staging site for commit https://github.com/staylor7/rare-diseases/pull/32/commits/05c882850da12a9759fc33372cd7aa1ea650ad85