search

staylor7 / rare-diseases

Catalog of Rare Diseases
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Migrate to the fun zoomable sunburst diagram #9

Closed quinnouyang closed 8 months ago

quinnouyang commented 11 months ago
SallyXue-0114 commented 11 months ago

What should the hierarchy of our CSV file be? For example, our CSV header is as follows: index, Disease, Disease_break, Category, Chakra, Nphenotype, Ngenes, Elite, Inheritance, Nvariants, Phenotype, Gene, Promoter, Malacards. Should we place 'Disease' in layer 1 (top layer) and all other elements in layer 2?

staylor7 commented 11 months ago

We can get rid of Disease_break - that was me trying to make line breaks in the disease names, just a hack that didn’t work.

I think that “Category” and “Chakra” should be layer 1, and everything else layer 2.

Aditi, the doctor I’m working with, assigned Indian chakras to each of the 12 disease categories - the chakras are what determine the musical scale for that category. So they are equivalent in the csv.

Thanks Sally!

On Dec 3, 2023, at 7:27 PM, SallyXue-0114 @.***> wrote:

What should the hierarchy of our CSV file be? For example, our CSV header is as follows: index, Disease, Disease_break, Category, Chakra, Nphenotype, Ngenes, Elite, Inheritance, Nvariants, Phenotype, Gene, Promoter, Malacards. Should we place 'Disease' in layer 1 (top layer) and all other elements in layer 2?

— Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/issues/9#issuecomment-1837697015, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKMFBA7ELD2SLU3UAELYHURHBAVCNFSM6AAAAABAFGHGK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGY4TOMBRGU. You are receiving this because you were mentioned.

quinnouyang commented 10 months ago

I made some progress on stratifying the data (I specified a more detailed hierarchy than the two layers that @staylor7 proposed.), though I could not get the sunburst to render yet. See https://github.com/staylor7/rare-diseases/blob/83aac099fee8e5cdb08a2a3b3ba5e7342018407a/src/sunburst.ts#L16C1-L26C2

(Accidently committed these to main, whoops.)

SallyXue-0114 commented 10 months ago

thanks quinn! Will take a look today!

staylor7 commented 10 months ago

I will try this too but I keep forgetting how to do the whole build thing in Terminal. Sorry I’m so behind - oy!

Steve

Stephen Taylor Professor of Music University of Illinois at Urbana-Champaign Co-director, Illinois Modern Ensemble www.stephenandrewtaylor.net 217 333-3712 office

On Dec 21, 2023, at 12:22 PM, SallyXue-0114 @.***> wrote:

thanks quinn! Will take a look today!

— Reply to this email directly, view it on GitHub https://github.com/staylor7/rare-diseases/issues/9#issuecomment-1866744313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPFIKJRXACCJ2FBV4U2GVDYKR5AFAVCNFSM6AAAAABAFGHGK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWG42DIMZRGM. You are receiving this because you were mentioned.

SallyXue-0114 commented 10 months ago

New updates from Sally:

  1. I managed to fix all the 'Problems' (the red wiggly lines) in Quinn's version of the code, but it's still not displaying anything. The issue might be related to the connection with main.ts? I've pushed my changes to the main branch.

  2. In the 'sunburst-js' branch: Earlier, I converted our data (CSV file) into a two-layer (the one @staylor7 proposed) stratified JSON file (hierarchy.json). Now, when I run script.js (I do this by using the 'Go Live' button in VSCode), it displays some kind of sunburst as shown in the following screenshot (this is just half of it; it's too large to capture entirely).

    sunburst

However, it's a bit messy at the moment (and sometimes freezes) because there's so much information in our CSV file.