search

staynomad / Nomad-Front

Prop-tech startup disrupting the budget homesharing industry
https://visitnomad.com
6 stars 0 forks source link

Stripe Payouts #468

Closed nishantbalaji closed 3 years ago

nishantbalaji commented 3 years ago

Closes #223 Closes #431

nishantbalaji commented 3 years ago

Test this concurrently with the PR in the Backend directory

nishantbalaji commented 3 years ago

Changes

nishantbalaji commented 3 years ago

I feel like the Payouts tab is a bit empty (only has one button on it) so we should experiment with adding more information to the page, ie. instructions on how to set up the Stripe connection. We should also play around with including it in the Settings tab which is currently empty.

Let's discuss this some more at the next meeting make a decision from there.

@aidenszeto Yeah I agree its a bit empty, but I didn't know where else to specifically put it. I also thought the stripe dashboard would be an integrated view but since its in a separate page we could just drop it in one of the other pages.

nishantbalaji commented 3 years ago

@nishantbalaji LGTM. Before we merge, could you add a comment on how to test/verify functionality? Not sure how Stripe manages testing transactions but we should make sure everything works in the testing environment first.

@aidenszeto To test with the testing environment, the keys have to be the testing keys. I think only the prod environment uses the live keys so anything we do with the testing keys will use the testing environment.

aidenszeto commented 3 years ago

I see. For the testing keys will you still need a valid account to connect with Stripe then?

Also how will Stripe know how much to pay out the hosts btw? Is that something we pass in?