staynomad / Nomad-Front

Prop-tech startup disrupting the budget homesharing industry
https://visitnomad.com
6 stars 0 forks source link

Added precommit hook to run Prettier #475

Closed aidenszeto closed 3 years ago

aidenszeto commented 3 years ago

Relevant issue

Closes #472

Summary of change

NOTE: this PR includes prettier formatting, thus there are quite a few lines changed

Testing/Verification

NOTE: if there are dependency tree issues with eslint version, do the following

  1. Delete package-lock.json
  2. Delete /node_modules
  3. Remove eslint dependency from package.json
  4. Re-install dependencies with yarn (not npm)
aidenszeto commented 3 years ago

Looks good but would we run yarn run format or something if we reinstall with yarn or would it still be npm?

Yeah I believe yarn run format would be equivalent to npm run format