staynomad / Nomad-Front

Prop-tech startup disrupting the budget homesharing industry
https://visitnomad.com
6 stars 0 forks source link

Updated signup to also log user in #520

Closed aidenszeto closed 3 years ago

aidenszeto commented 3 years ago

Relevant issue

Closes #496

Summary of change

Testing/Verification

aidenszeto commented 3 years ago

Broke when I clicked sign-up

image image image

Did you try using the Google signup? This PR is for signing up without Google

syd-tan commented 3 years ago

It took me back to the main page after I signed up without being logged in.

nishantbalaji commented 3 years ago

Broke when I clicked sign-up image image image

Did you try using the Google signup? This PR is for signing up without Google

@aidenszeto nope, just normal sign up

aidenszeto commented 3 years ago

It took me back to the main page after I signed up without being logged in.

Thanks for the catch, should be fixed with new commit

aidenszeto commented 3 years ago

Are you on the right branch? The error from console shows something happening on line 47 and the params access on line 47 is only on master

nishantbalaji commented 3 years ago

@aidenszeto Odd, I'll delete and reclone the branch

nishantbalaji commented 3 years ago

image on the right branch and i see this so idrk

created a new user by default and checked host box so maybe thats causing something but im not sure

aidenszeto commented 3 years ago

@nishantbalaji looks like you were right about the error, new backend changes (#187) should fix the issue you found though