staynomad / Nomad-Front

Prop-tech startup disrupting the budget homesharing industry
https://visitnomad.com
6 stars 0 forks source link

Updated filter values to persist through searches #535

Closed aidenszeto closed 2 years ago

aidenszeto commented 3 years ago

Relevant issue

Closes #525

Summary of change

Testing/Verification

aidenszeto commented 3 years ago

The functionality of the filter values persisting works perfectly (after clicking search)! However, I do want to bring attention to the situation where the user clicks on the filter button then escapes the modal and clicks it again. The filter values don't persist, which may not be a huge deal but it's just a weird use-case scenario we might want to look into.

Also, in the ticket task, we suggested implementing a clear filters option, but that could be left for another time if that's not a huge priority.

Thanks for pointing those out, just added the clear button with latest commit. I think it might be alright to have the filter not save when the user clicks out of the modal and rather have it save only when the filter is applied. Anyone else have thoughts?