staynomad / Nomad-Front

Prop-tech startup disrupting the budget homesharing industry

https://visitnomad.com

6 stars 0 forks source link

State Dropdown && Confirm Search #536

Closed KevinYuCode closed 2 years ago

KevinYuCode commented 3 years ago

Relevant issue

Closes #531 closes #524

Summary of change

Made the state options drop-down menu conditionally render the states only if the country "United States" was selected.
Also removed the state name if the country name is changed afterwards
Now, after selecting the filter options and selecting "confirm" the new listings are populated and the URL is refreshed.

Testing/Verification

Select any country besides the "United States" and check if the options for the states appear (There should be none)
Select "United States" then select the "states" dropdown menu and see if the states appear.
After selecting a state, try changing the country and see if the state name disappears.
Test out different filter options and click confirm. Then see if the respective listings show up.

KevinYuCode commented 3 years ago

@aidenszeto Not a bad idea, since in the future other countries like Canada have Provinces/Territories and the "state" dropdown menu wouldn't make much sense for that. Also, another consideration would be to list the countries that NoMad supports, rather than having a long list of countries that aren't supported. That way it saves time for users to filter the search rather than scrolling alphabetically to the United States.

aidenszeto commented 3 years ago

@aidenszeto Not a bad idea, since in the future other countries like Canada have Provinces/Territories and the "state" dropdown menu wouldn't make much sense for that. Also, another consideration would be to list the countries that NoMad supports, rather than having a long list of countries that aren't supported. That way it saves time for users to filter the search rather than scrolling alphabetically to the United States.

That's a good point, the additional countries may make it more confusing than it needs to be. Eventually we should have the process automated where new countries that are added automatically add to the country dropdown (ie. when a host creates a listing in a new country). For this ticket though I think we can keep the scope as is and create a new ticket for the automation.