staynomad / Nomad-Front

Prop-tech startup disrupting the budget homesharing industry

https://visitnomad.com

6 stars 0 forks source link

Updated listings containers to hide draft listings #543

Closed aidenszeto closed 2 years ago

aidenszeto commented 2 years ago

Relevant issue

Closes #542

Summary of change

Updated public listing containers to hide draft or expired (inactive) listings

Testing/Verification

Listings formatted like the third listing in the image above should be hidden in all public listing containers
Draft listings should still be visible in MyAccount when a host has "Show Drafts" toggled on in MyListings

syd-tan commented 2 years ago

My draft still shows up in featured and the recently posted listings for some reason.

aidenszeto commented 2 years ago

My draft still shows up in featured and the recently posted listings for some reason.

Not sure if this may be related but it looks like there are 2 identical listings called "Cozy 2 Bed 2 Bath near Sac Town Center" in the dev database. One is active meaning it should be displayed in the featured section and the other is inactive.

Could this be causing the behavior you found?

syd-tan commented 2 years ago

@aidenszeto Oh i do remember trying to make the same listing twice so that might be the case - but this means that there's an error with the listings tab in MyProfile since i only saw the expired one

aidenszeto commented 2 years ago

@syd-tan thanks for the catch. It looks like we were still hiding expired listings even though all expired listings should already be automatically be converted to drafts (from the ticket you worked on a while back). That behavior was legacy and the most recent commit should have the fixes. I left in the code for filtering expired listings in case we want to mess with that in the future tho.

Also I manually changed both of these to drafts since they were both expired. I'm guessing we had created one of them prior to the automatic nodecron draft conversion which was why it was left as active.